Handle direction control in compositor Animations

Handle direction control in compositor Animations

This patch is the blink side.
The chromium side is handled on issue #180153010

It doesn't revert functions anymore in blink. Instead, it sets the
direction parameter to WebAnimation, which will in turn pass it to the
compositor

BUG=348071
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170491

[a.renevier, 2014-02-28 21:38:11]

new patch: add a bug number

[mithro-old, 2014-03-03 06:19:36]

Hi a.renevier,

At a quick glance, what this patch is doing looks good. I'm excited to see the
compositor gain direction support and remove the need for the reversing code in
Blink!

Can you add links between the Chrome side/Blink side of these CLs?

I'll add more comments shortly.

Thanks!

Tim

[a.renevier, 2014-03-03 22:58:48]

new patch: add a reference to chromium issue

[a.renevier, 2014-03-03 23:01:22]

On 2014/03/03 22:58:48, a.renevier wrote:
> new patch: add a reference to chromium issue

Looks like uploading the new patch didn't change the description...

[ajuma, 2014-03-03 23:51:51]

On 2014/03/03 23:01:22, a.renevier wrote:
> On 2014/03/03 22:58:48, a.renevier wrote:
> > new patch: add a reference to chromium issue
> 
> Looks like uploading the new patch didn't change the description...

Note that you can edit the description using the "Edit Issue" link on the top
left.

[dstockwell, 2014-03-05 02:07:19]

looks good, one nit

please ping after cla update (as mentioned here:
https://codereview.chromium.org/180153010/#msg7)

https://codereview.chromium.org/178263006/diff/40001/Source/core/animation/Co...
File Source/core/animation/CompositorAnimationsImpl.h (right):

https://codereview.chromium.org/178263006/diff/40001/Source/core/animation/Co...
Source/core/animation/CompositorAnimationsImpl.h:50: Direction direction;
Can't we reuse Timing::PlaybackDirection?

[a.renevier, 2014-03-11 22:28:59]

I got confirmation from my company that the cla was done for me. What are the
next steps now?

[jamesr, 2014-03-11 23:07:26]

https://codereview.chromium.org/178263006/diff/40001/public/platform/WebAnima...
File public/platform/WebAnimation.h (right):

https://codereview.chromium.org/178263006/diff/40001/public/platform/WebAnima...
public/platform/WebAnimation.h:56: Normal = 0,
these should be prefixed with the enum name. see
http://www.chromium.org/blink/public-c-api

[a.renevier, 2014-03-20 00:02:51]

new patch: rebases against tot; fixes enum naming issue

[dstockwell, 2014-03-20 00:23:48]

lgtm

[a.renevier, 2014-03-31 20:41:17]

The CQ bit was checked by a.renevier@samsung.com

[commit-bot: I haz the power, 2014-03-31 20:41:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/a.renevier@samsung.com/178263006/60001

[commit-bot: I haz the power, 2014-03-31 20:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-31 20:51:53]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[a.renevier, 2014-03-31 21:04:55]

The CQ bit was checked by a.renevier@samsung.com

[commit-bot: I haz the power, 2014-03-31 21:05:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/a.renevier@samsung.com/178263006/60001

[commit-bot: I haz the power, 2014-03-31 21:15:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-31 21:15:22]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[a.renevier, 2014-03-31 21:34:16]

On 2014/03/31 21:15:22, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on blink_presubmit

Oh, it misses LGTM from a owner of WebKit/public

[abarth-chromium, 2014-03-31 22:52:20]

public/ LGTM

[a.renevier, 2014-03-31 22:52:52]

The CQ bit was checked by a.renevier@samsung.com

[commit-bot: I haz the power, 2014-03-31 22:52:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/a.renevier@samsung.com/178263006/60001

[commit-bot: I haz the power, 2014-04-01 00:00:48]

Change committed as 170491