Source/core/animation/CompositorAnimationsImpl.h - Issue 178263006: Handle direction control in compositor Animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/CompositorAnimationsImpl.h

Issue 178263006: Handle direction control in compositor Animations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: new patch: rebases against tot; fixes enum naming issue Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/CompositorAnimationsImpl.h

diff --git a/Source/core/animation/CompositorAnimationsImpl.h b/Source/core/animation/CompositorAnimationsImpl.h

index 4ad07bd1c140513dee6ce2e65573a85d4ece2f9b..70e677060538c27299dc8341517dd00708e32cb7 100644

--- a/Source/core/animation/CompositorAnimationsImpl.h

+++ b/Source/core/animation/CompositorAnimationsImpl.h

@@ -41,8 +41,7 @@ typedef KeyframeEffectModel::PropertySpecificKeyframeVector KeyframeVector;

class CompositorAnimationsImpl {

private:

struct CompositorTiming {

- bool reverse;

- bool alternate;

+ Timing::PlaybackDirection direction;

double scaledDuration;

double scaledTimeOffset;

int adjustedIterationCount;

@@ -52,7 +51,7 @@ private:

static void getAnimationOnCompositor(const Timing&, const KeyframeEffectModel&, Vector<OwnPtr<blink::WebAnimation> >& animations);

- static void addKeyframesToCurve(blink::WebAnimationCurve&, const KeyframeVector&, bool reverse);

+ static void addKeyframesToCurve(blink::WebAnimationCurve&, const KeyframeVector&);

friend class CompositorAnimations;

friend class AnimationCompositorAnimationsTest;