[telemetry] Add page load interaction to V8.todomvc

[telemetry] Add page load interaction to V8.todomvc

The timeline based measurement requires an interaction to output
anything.

BUG=593406
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
R=cbruni@chromium.org,ulan@chromium.org,eakuefner@chromium.org,skyostil@chromium.org

Committed: https://crrev.com/7c3ab2038968911557fdac7b782732c766f5f099
Cr-Commit-Position: refs/heads/master@{#380629}

[jochen (gone - plz use gerrit), 2016-03-10 11:41:45]

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:38: requestAnimationFrame(function() {
i wonder whether the page load interaction should end at the first frame, or
when the window.onload event fires

[Sami, 2016-03-10 12:30:34]

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:22: INTERACTION_NAME = "Interaction.PageLoading"
nit: Single quote strings please.

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:32: "console.time('" + INTERACTION_NAME + "');")
nit: How about creating an action_runner.Interaction() object and calling
Begin() here and End() in RunPageInteractions?

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:38: requestAnimationFrame(function() {
On 2016/03/10 11:41:45, jochen wrote:
> i wonder whether the page load interaction should end at the first frame, or
> when the window.onload event fires

I'm wondering if both are a little early for some of the frameworks? I checked a
couple by placing a load breakpoint, and none of the pages had any real content
up at that point (even after waiting a few rAFs after onload). Maybe that's fine
if you mostly care about the parsing stage, but it might be worth coming up with
a way to stop only when there's something more meaningful on the screen.

You could also take a peek at a few traces to see if the interaction record
covers the area you care about.

[Camillo Bruni, 2016-03-10 12:30:55]

lhtm

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:38: requestAnimationFrame(function() {
On 2016/03/10 at 11:41:45, jochen wrote:
> i wonder whether the page load interaction should end at the first frame, or
when the window.onload event fires

It should probably end with window.onLoad, since you probably get the first full
paint before?

[Camillo Bruni, 2016-03-10 12:31:17]

keyboard off by one: lgtm it is

[jochen (gone - plz use gerrit), 2016-03-10 14:09:22]

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:32: "console.time('" + INTERACTION_NAME + "');")
On 2016/03/10 at 12:30:34, Sami wrote:
> nit: How about creating an action_runner.Interaction() object and calling
Begin() here and End() in RunPageInteractions?

there is no action runner that would live long enough for this to work.

there's also a more fundamental problem: We can't evaluate console.time() before
the iframe is completely setup, e.g. WindowProxy::initialize will always be
outside of this interaction

[Camillo Bruni, 2016-03-10 15:12:53]

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
File tools/perf/page_sets/todomvc.py (right):

https://codereview.chromium.org/1782033002/diff/1/tools/perf/page_sets/todomv...
tools/perf/page_sets/todomvc.py:38: requestAnimationFrame(function() {
On 2016/03/10 at 12:30:34, Sami wrote:
> On 2016/03/10 11:41:45, jochen wrote:
> > i wonder whether the page load interaction should end at the first frame, or
> > when the window.onload event fires
> 
> I'm wondering if both are a little early for some of the frameworks? I checked
a couple by placing a load breakpoint, and none of the pages had any real
content up at that point (even after waiting a few rAFs after onload). Maybe
that's fine if you mostly care about the parsing stage, but it might be worth
coming up with a way to stop only when there's something more meaningful on the
screen.
> 
> You could also take a peek at a few traces to see if the interaction record
covers the area you care about.

how about just waiting 4 seconds or so?

[jochen (gone - plz use gerrit), 2016-03-11 07:57:41]

ptal

I think that's as good as it'll get with TBMv1, so I'd like to land this as is
before we start looking at TBMv2 integration.

[Sami, 2016-03-11 12:17:17]

lgtm -- let's revisit with TBMv2.

[jochen (gone - plz use gerrit), 2016-03-11 12:17:35]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-03-11 12:17:36]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1782033002/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2016-03-11 12:17:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782033002/40001

[commit-bot: I haz the power, 2016-03-11 14:47:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-11 14:49:24]

Description was changed from

==========
[telemetry] Add page load interaction to V8.todomvc

The timeline based measurement requires an interaction to output
anything.

BUG=593406
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
R=cbruni@chromium.org,ulan@chromium.org,eakuefner@chromium.org,skyostil@chrom...
==========

to

==========
[telemetry] Add page load interaction to V8.todomvc

The timeline based measurement requires an interaction to output
anything.

BUG=593406
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
R=cbruni@chromium.org,ulan@chromium.org,eakuefner@chromium.org,skyostil@chrom...

Committed: https://crrev.com/7c3ab2038968911557fdac7b782732c766f5f099
Cr-Commit-Position: refs/heads/master@{#380629}
==========

[commit-bot: I haz the power, 2016-03-11 14:49:25]

Patchset 3 (id:??) landed as
https://crrev.com/7c3ab2038968911557fdac7b782732c766f5f099
Cr-Commit-Position: refs/heads/master@{#380629}