[telemetry] Add page load interaction to V8.todomvc

tools/perf/page_sets/todomvc.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from telemetry.page import page as page_module
 from telemetry.page import shared_page_state
 from telemetry import story
 
 
 URL_LIST = [
     ('Polymer', 'http://todomvc.com/examples/polymer'),
     ('AngularJS', 'http://todomvc.com/examples/angularjs'),
     ('React', 'http://todomvc.com/examples/react'),
     ('Backbone.js', 'http://todomvc.com/examples/backbone'),
     ('Ember.js', 'http://todomvc.com/examples/emberjs'),
     ('Closure', 'http://todomvc.com/examples/closure'),
     ('GWT', 'http://todomvc.com/examples/gwt'),
     ('Dart', 'http://todomvc.com/examples/vanilladart/build/web'),
     ('Vanilla JS', 'http://todomvc.com/examples/vanillajs'),
 ]
 
+INTERACTION_NAME = "Interaction.PageLoading"

[Sami, 2016/03/10 12:30:34]

nit: Single quote strings please.

+
 
 class TodoMVCPage(page_module.Page):
 
   def __init__(self, url, page_set, name):
     super(TodoMVCPage, self).__init__(
         url=url, page_set=page_set, name=name,
         shared_page_state_class=shared_page_state.SharedDesktopPageState)
+    self.script_to_evaluate_on_commit = (
+        "console.time('" + INTERACTION_NAME + "');")

[Sami, 2016/03/10 12:30:34]

nit: How about creating an action_runner.Interaction() object and calling
Begin() here and End() in RunPageInteractions?

[jochen (gone - plz use gerrit), 2016/03/10 14:09:22]

there is no action runner that would live long enough for this to work.

there's also a more fundamental problem: We can't evaluate console.time() before
the iframe is completely setup, e.g. WindowProxy::initialize will always be
outside of this interaction

 
   def RunPageInteractions(self, action_runner):
-    pass
+    action_runner.ExecuteJavaScript(
+        """
+        this.hasRunRAF = 0;
+        requestAnimationFrame(function() {

[jochen (gone - plz use gerrit), 2016/03/10 11:41:45]

i wonder whether the page load interaction should end at the first frame, or
when the window.onload event fires

[Sami, 2016/03/10 12:30:34]

I'm wondering if both are a little early for some of the frameworks? I checked a
couple by placing a load breakpoint, and none of the pages had any real content
up at that point (even after waiting a few rAFs after onload). Maybe that's fine
if you mostly care about the parsing stage, but it might be worth coming up with
a way to stop only when there's something more meaningful on the screen.

You could also take a peek at a few traces to see if the interaction record
covers the area you care about.

[Camillo Bruni, 2016/03/10 12:30:55]

It should probably end with window.onLoad, since you probably get the first full
paint before?

[Camillo Bruni, 2016/03/10 15:12:53]

how about just waiting 4 seconds or so?

+            this.hasRunRAF = 1;
+            console.timeEnd('%s');
+        });
+        """ % INTERACTION_NAME
+    )
+    action_runner.WaitForJavaScriptCondition("this.hasRunRAF == 1")
 
 
 class TodoMVCPageSet(story.StorySet):
 
   """ TodoMVC examples """
 
   def __init__(self):
     super(TodoMVCPageSet, self).__init__(
       archive_data_file='data/todomvc.json',
       cloud_storage_bucket=story.PUBLIC_BUCKET)
 
     for name, url in URL_LIST:
       self.AddStory(TodoMVCPage(url, self, name))