tools/perf/benchmarks/v8.py - Issue 1782033002: [telemetry] Add page load interaction to V8.todomvc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/v8.py

Issue 1782033002: [telemetry] Add page load interaction to V8.todomvc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/v8.py

diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py

index aebdf646ae594c615929f0066a691961d415d370..5164ff93d2e120a8528db10a0ed2d50a95a51607 100644

--- a/tools/perf/benchmarks/v8.py

+++ b/tools/perf/benchmarks/v8.py

@@ -125,7 +125,9 @@ class V8TodoMVC(perf_benchmark.PerfBenchmark):

page_set = page_sets.TodoMVCPageSet

def CreateTimelineBasedMeasurementOptions(self):

- category_filter = tracing_category_filter.TracingCategoryFilter('v8')

+ category_filter = tracing_category_filter.CreateMinimalOverheadFilter()

+ category_filter.AddIncludedCategory('v8')

+ category_filter.AddIncludedCategory('blink.console')

options = timeline_based_measurement.Options(category_filter)

options.SetLegacyTimelineBasedMetrics([v8_execution.V8ExecutionMetric()])

return options

« no previous file with comments | « no previous file | tools/perf/page_sets/todomvc.py » ('j') | no next file with comments »