Avoid specifying DART_SHARED_LIB in the static library GN targets

Avoid specifying DART_SHARED_LIB in the static library GN targets

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/a044cf9633f92a45c46e4250e89df8a606d6c20b

[Chinmay, 2016-03-10 01:00:57]

chinmaygarde@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com

[Chinmay, 2016-03-10 01:00:58]

We now package the Flutter embedder as a framework. This patch avoids leaking
some Dart symbols from the dylib.

[rmacnak, 2016-03-10 02:15:31]

LGTM

I believe this is only part of the standalone VM to support native extensions,
which won't apply for Flutter.

[Cutch, 2016-03-10 17:02:42]

On 2016/03/10 02:15:31, rmacnak wrote:
> LGTM
> 
> I believe this is only part of the standalone VM to support native extensions,
> which won't apply for Flutter.

They will apply to Flutter in the near future.

[zra, 2016-03-10 18:44:19]

zra@google.com changed reviewers:
+ zra@google.com

[zra, 2016-03-10 18:44:19]

Patched this in, and it does not break the Mojo build.

[Chinmay, 2016-03-10 19:11:21]

On 2016/03/10 at 17:02:42, johnmccutchan wrote:
> 
> They will apply to Flutter in the near future.

Flutter already supports native extensions by packaging up and loading service
implementations as dylibs(iOS) or Jars(Android) and communicating over Mojo
interfaces (with some provisions to help Flutter handle breakages in the Mojo
ABI
https://github.com/flutter/engine/blob/master/sky/services/dynamic/dynamic_se...).

Allowing Native extensions this way is also interesting though. If I can get a
better sense of how to support this in all cases (load from file, script
snapshotting and precomp), I would love to wire this back up. For now, I just
wanted to avoid exposing these symbols.

[Chinmay, 2016-03-10 19:12:27]

Description was changed from

==========
Avoid specifying DART_SHARED_LIB in the static library GN targets
==========

to

==========
Avoid specifying DART_SHARED_LIB in the static library GN targets

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a044cf9633f92a45c46e4250e89df8a606d6c20b
==========

[Chinmay, 2016-03-10 19:12:28]

Committed patchset #1 (id:1) manually as
a044cf9633f92a45c46e4250e89df8a606d6c20b (presubmit successful).