Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Side by Side Diff: runtime/BUILD.gn

Issue 1781943002: Avoid specifying DART_SHARED_LIB in the static library GN targets (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 # TODO(zra): These build arguments should likely be moved to a gni file that is 5 # TODO(zra): These build arguments should likely be moved to a gni file that is
6 # included in BUILD.gn files that care about the values of the flags. For now, 6 # included in BUILD.gn files that care about the values of the flags. For now,
7 # since the GN build only happens as part of a Mojo build there is no need for 7 # since the GN build only happens as part of a Mojo build there is no need for
8 # the indirection. 8 # the indirection.
9 declare_args() { 9 declare_args() {
10 # Instead of using is_debug, we introduce a different flag for specifying a 10 # Instead of using is_debug, we introduce a different flag for specifying a
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 "include/dart_mirrors_api.h", 164 "include/dart_mirrors_api.h",
165 "include/dart_native_api.h", 165 "include/dart_native_api.h",
166 "include/dart_tools_api.h", 166 "include/dart_tools_api.h",
167 "vm/dart_api_impl.cc", 167 "vm/dart_api_impl.cc",
168 "vm/debugger_api_impl.cc", 168 "vm/debugger_api_impl.cc",
169 "vm/mirrors_api_impl.cc", 169 "vm/mirrors_api_impl.cc",
170 "vm/native_api_impl.cc", 170 "vm/native_api_impl.cc",
171 "vm/version.h", 171 "vm/version.h",
172 "$target_gen_dir/version.cc", 172 "$target_gen_dir/version.cc",
173 ] 173 ]
174 defines = [
175 # Using DART_SHARED_LIB to export the Dart API entries.
176 "DART_SHARED_LIB",
177 ]
178 } 174 }
179 175
180 176
181 static_library("libdart_precompiled_runtime") { 177 static_library("libdart_precompiled_runtime") {
182 configs += [":dart_config_no_precompiler"] 178 configs += [":dart_config_no_precompiler"]
183 deps = [ 179 deps = [
184 "vm:libdart_lib_precompiled_runtime", 180 "vm:libdart_lib_precompiled_runtime",
185 "vm:libdart_vm_precompiled_runtime", 181 "vm:libdart_vm_precompiled_runtime",
186 "third_party/double-conversion/src:libdouble_conversion", 182 "third_party/double-conversion/src:libdouble_conversion",
187 ":generate_version_cc_file", 183 ":generate_version_cc_file",
188 ] 184 ]
189 include_dirs = [ 185 include_dirs = [
190 ".", 186 ".",
191 ] 187 ]
192 public_configs = [":dart_public_config"] 188 public_configs = [":dart_public_config"]
193 sources = [ 189 sources = [
194 "include/dart_api.h", 190 "include/dart_api.h",
195 "include/dart_mirrors_api.h", 191 "include/dart_mirrors_api.h",
196 "include/dart_native_api.h", 192 "include/dart_native_api.h",
197 "include/dart_tools_api.h", 193 "include/dart_tools_api.h",
198 "vm/dart_api_impl.cc", 194 "vm/dart_api_impl.cc",
199 "vm/debugger_api_impl.cc", 195 "vm/debugger_api_impl.cc",
200 "vm/mirrors_api_impl.cc", 196 "vm/mirrors_api_impl.cc",
201 "vm/native_api_impl.cc", 197 "vm/native_api_impl.cc",
202 "vm/version.h", 198 "vm/version.h",
203 "$target_gen_dir/version.cc", 199 "$target_gen_dir/version.cc",
204 ] 200 ]
205 defines = [ 201 defines = [
206 # Using DART_SHARED_LIB to export the Dart API entries.
207 "DART_SHARED_LIB",
208 "DART_PRECOMPILED_RUNTIME", 202 "DART_PRECOMPILED_RUNTIME",
209 ] 203 ]
210 } 204 }
211 205
212 206
213 action("generate_version_cc_file") { 207 action("generate_version_cc_file") {
214 deps = [ 208 deps = [
215 ":libdart_dependency_helper", 209 ":libdart_dependency_helper",
216 ] 210 ]
217 inputs = [ 211 inputs = [
(...skipping 21 matching lines...) Expand all
239 "vm:libdart_lib_nosnapshot", 233 "vm:libdart_lib_nosnapshot",
240 "vm:libdart_lib", 234 "vm:libdart_lib",
241 "vm:libdart_vm", 235 "vm:libdart_vm",
242 "vm:libdart_platform", 236 "vm:libdart_platform",
243 "third_party/double-conversion/src:libdouble_conversion", 237 "third_party/double-conversion/src:libdouble_conversion",
244 ] 238 ]
245 sources = [ 239 sources = [
246 "vm/libdart_dependency_helper.cc", 240 "vm/libdart_dependency_helper.cc",
247 ] 241 ]
248 } 242 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698