Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: runtime/BUILD.gn

Issue 1781943002: Avoid specifying DART_SHARED_LIB in the static library GN targets (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/BUILD.gn
diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn
index 62b69fb6ecd5808a393b7daad78835fac8ae8cbe..6e987c46f0718069d52bb1a95f3f7a11b6c2d6a8 100644
--- a/runtime/BUILD.gn
+++ b/runtime/BUILD.gn
@@ -171,10 +171,6 @@ static_library("libdart") {
"vm/version.h",
"$target_gen_dir/version.cc",
]
- defines = [
- # Using DART_SHARED_LIB to export the Dart API entries.
- "DART_SHARED_LIB",
- ]
}
@@ -203,8 +199,6 @@ static_library("libdart_precompiled_runtime") {
"$target_gen_dir/version.cc",
]
defines = [
- # Using DART_SHARED_LIB to export the Dart API entries.
- "DART_SHARED_LIB",
"DART_PRECOMPILED_RUNTIME",
]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698