Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1781523002: [wasm] All strings are length-prefixed and inline (Closed)

Created:
4 years, 9 months ago by binji
Modified:
4 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] All strings are length-prefixed and inline R=titzer@chromium.org Committed: https://crrev.com/ca0dbaece0083535e8ba3d03d49993d33365cf3a Cr-Commit-Position: refs/heads/master@{#34637}

Patch Set 1 #

Patch Set 2 : merge master #

Patch Set 3 : fix windows #

Total comments: 2

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -248 lines) Patch
M src/compiler/wasm-compiler.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 7 chunks +21 lines, -15 lines 0 comments Download
M src/wasm/decoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/encoder.cc View 1 2 5 chunks +11 lines, -8 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 7 chunks +19 lines, -13 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/wasm/wasm-module.h View 1 4 chunks +15 lines, -11 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 3 7 chunks +43 lines, -32 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 6 chunks +7 lines, -37 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 24 chunks +108 lines, -124 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
binji
4 years, 9 months ago (2016-03-09 01:12:35 UTC) #1
titzer
lgtm other one merge item below https://codereview.chromium.org/1781523002/diff/40001/src/wasm/ast-decoder.h File src/wasm/ast-decoder.h (right): https://codereview.chromium.org/1781523002/diff/40001/src/wasm/ast-decoder.h#newcode161 src/wasm/ast-decoder.h:161: inline uint16_t read_entry(Decoder* ...
4 years, 9 months ago (2016-03-09 08:18:17 UTC) #2
binji
https://codereview.chromium.org/1781523002/diff/40001/src/wasm/ast-decoder.h File src/wasm/ast-decoder.h (right): https://codereview.chromium.org/1781523002/diff/40001/src/wasm/ast-decoder.h#newcode161 src/wasm/ast-decoder.h:161: inline uint16_t read_entry(Decoder* decoder, int i) { On 2016/03/09 ...
4 years, 9 months ago (2016-03-09 18:34:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781523002/60001
4 years, 9 months ago (2016-03-09 18:34:30 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-09 18:55:34 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:56:37 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ca0dbaece0083535e8ba3d03d49993d33365cf3a
Cr-Commit-Position: refs/heads/master@{#34637}

Powered by Google App Engine
This is Rietveld 408576698