test/unittests/wasm/ast-decoder-unittest.cc - Issue 1781523002: [wasm] All strings are length-prefixed and inline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/wasm/ast-decoder-unittest.cc

Issue 1781523002: [wasm] All strings are length-prefixed and inline (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: comment Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/wasm/ast-decoder-unittest.cc

diff --git a/test/unittests/wasm/ast-decoder-unittest.cc b/test/unittests/wasm/ast-decoder-unittest.cc

index 95a791b9a61d44bea91a078dc38c8010a07195b9..306b28dfc358ce1a9f3d40c549dc892bc6dd7980 100644

--- a/test/unittests/wasm/ast-decoder-unittest.cc

+++ b/test/unittests/wasm/ast-decoder-unittest.cc

@@ -1037,7 +1037,7 @@ class TestModuleEnv : public ModuleEnv {

linker = nullptr;

}

byte AddGlobal(MachineType mem_type) {

- mod.globals.push_back({0, mem_type, 0, false});

+ mod.globals.push_back({0, 0, mem_type, 0, false});

CHECK(mod.globals.size() <= 127);

return static_cast<byte>(mod.globals.size() - 1);

}