[wasm] All strings are length-prefixed and inline

src/wasm/wasm-module.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/macro-assembler.h"
 #include "src/objects.h"
 #include "src/v8.h"
 
 #include "src/simulator.h"
 
@@ skipping 30 matching lines @@
 
   os << " code bytes: "
      << (function.code_end_offset - function.code_start_offset);
   return os;
 }
 
 std::ostream& operator<<(std::ostream& os, const WasmFunctionName& pair) {
   os << "#" << pair.function_->func_index << ":";
   if (pair.function_->name_offset > 0) {
     if (pair.module_) {
-      os << pair.module_->GetName(pair.function_->name_offset);
+      WasmName name = pair.module_->GetName(pair.function_->name_offset,
+                                            pair.function_->name_length);
+      os.write(name.name, name.length);
     } else {
       os << "+" << pair.function_->func_index;
     }
   } else {
     os << "?";
   }
   return os;
 }
 
 // A helper class for compiling multiple wasm functions that offers
@@ skipping 211 matching lines @@
       module_end(nullptr),
       min_mem_pages(0),
       max_mem_pages(0),
       mem_export(false),
       mem_external(false),
       start_function_index(-1),
       origin(kWasmOrigin) {}
 
 static MaybeHandle<JSFunction> ReportFFIError(ErrorThrower& thrower,
                                               const char* error, uint32_t index,
-                                              const char* module_cstr,
-                                              const char* function_cstr) {
-  if (function_cstr) {
-    thrower.Error("Import #%d module=\"%s\" function=\"%s\" error: %s", index,
-                  module_cstr, function_cstr, error);
+                                              wasm::WasmName module_name,
+                                              wasm::WasmName function_name) {
+  if (function_name.name) {
+    thrower.Error("Import #%d module=\"%.*s\" function=\"%.*s\" error: %s",
+                  index, module_name.length, module_name.name,
+                  function_name.length, function_name.name, error);
   } else {
-    thrower.Error("Import #%d module=\"%s\" error: %s", index, module_cstr,
-                  error);
+    thrower.Error("Import #%d module=\"%.*s\" error: %s", index,
+                  module_name.length, module_name.name, error);
   }
   thrower.Error("Import ");
   return MaybeHandle<JSFunction>();
 }
 
 static MaybeHandle<JSFunction> LookupFunction(
     ErrorThrower& thrower, Factory* factory, Handle<JSObject> ffi,
-    uint32_t index, const char* module_cstr, const char* function_cstr) {
+    uint32_t index, wasm::WasmName module_name, wasm::WasmName function_name) {
   if (ffi.is_null()) {
-    return ReportFFIError(thrower, "FFI is not an object", index, module_cstr,
-                          function_cstr);
+    return ReportFFIError(thrower, "FFI is not an object", index, module_name,
+                          function_name);
   }
 
   // Look up the module first.
-  Handle<String> name = factory->InternalizeUtf8String(module_cstr);
+  Handle<String> name = factory->InternalizeUtf8String(
+      Vector<const char>(module_name.name, module_name.length));
   MaybeHandle<Object> result = Object::GetProperty(ffi, name);
   if (result.is_null()) {
-    return ReportFFIError(thrower, "module not found", index, module_cstr,
-                          function_cstr);
+    return ReportFFIError(thrower, "module not found", index, module_name,
+                          function_name);
   }
 
   Handle<Object> module = result.ToHandleChecked();
 
   if (!module->IsJSReceiver()) {
     return ReportFFIError(thrower, "module is not an object or function", index,
-                          module_cstr, function_cstr);
+                          module_name, function_name);
   }
 
   Handle<Object> function;
-  if (function_cstr) {
+  if (function_name.name) {
     // Look up the function in the module.
-    Handle<String> name = factory->InternalizeUtf8String(function_cstr);
+    Handle<String> name = factory->InternalizeUtf8String(
+        Vector<const char>(function_name.name, function_name.length));
     MaybeHandle<Object> result = Object::GetProperty(module, name);
     if (result.is_null()) {
-      return ReportFFIError(thrower, "function not found", index, module_cstr,
-                            function_cstr);
+      return ReportFFIError(thrower, "function not found", index, module_name,
+                            function_name);
     }
     function = result.ToHandleChecked();
   } else {
     // No function specified. Use the "default export".
     function = module;
   }
 
   if (!function->IsJSFunction()) {
-    return ReportFFIError(thrower, "not a function", index, module_cstr,
-                          function_cstr);
+    return ReportFFIError(thrower, "not a function", index, module_name,
+                          function_name);
   }
 
   return Handle<JSFunction>::cast(function);
 }
 
 // Instantiates a wasm module as a JSObject.
 //  * allocates a backing store of {mem_size} bytes.
 //  * installs a named property "memory" for that buffer if exported
 //  * installs named properties on the object for exported functions
 //  * compiles wasm code to machine code
@@ skipping 50 matching lines @@
   WasmLinker linker(isolate, functions.size());
   ModuleEnv module_env;
   module_env.module = this;
   module_env.instance = &instance;
   module_env.linker = &linker;
   module_env.origin = origin;
 
   if (import_table.size() > 0) {
     instance.import_code.reserve(import_table.size());
     for (const WasmImport& import : import_table) {
-      const char* module_cstr = GetNameOrNull(import.module_name_offset);
-      const char* function_cstr = GetNameOrNull(import.function_name_offset);
+      WasmName module_name =
+          GetNameOrNull(import.module_name_offset, import.module_name_length);
+      WasmName function_name = GetNameOrNull(import.function_name_offset,
+                                             import.function_name_length);
       MaybeHandle<JSFunction> function = LookupFunction(
-          thrower, factory, ffi, index, module_cstr, function_cstr);
+          thrower, factory, ffi, index, module_name, function_name);
       if (function.is_null()) return MaybeHandle<JSObject>();
       Handle<Code> code = compiler::CompileWasmToJSWrapper(
           isolate, &module_env, function.ToHandleChecked(), import.sig,
-          module_cstr, function_cstr);
+          module_name, function_name);
       instance.import_code.push_back(code);
       index++;
     }
   }
 
   //-------------------------------------------------------------------------
   // Compile all functions in the module.
   //-------------------------------------------------------------------------
 
   // First pass: compile each function and initialize the code table.
   index = 0;
   for (const WasmFunction& func : functions) {
     if (thrower.error()) break;
     DCHECK_EQ(index, func.func_index);
 
-    const char* cstr = GetName(func.name_offset);
-    Handle<String> name = factory->InternalizeUtf8String(cstr);
+    WasmName str = GetName(func.name_offset, func.name_length);
+    WasmName str_null = {nullptr, 0};
+    Handle<String> name = factory->InternalizeUtf8String(
+        Vector<const char>(str.name, str.length));
     Handle<Code> code = Handle<Code>::null();
     Handle<JSFunction> function = Handle<JSFunction>::null();
     if (func.external) {
       // Lookup external function in FFI object.
       MaybeHandle<JSFunction> function =
-          LookupFunction(thrower, factory, ffi, index, cstr, nullptr);
+          LookupFunction(thrower, factory, ffi, index, str, str_null);
       if (function.is_null()) return MaybeHandle<JSObject>();
       code = compiler::CompileWasmToJSWrapper(isolate, &module_env,
                                               function.ToHandleChecked(),
-                                              func.sig, cstr, nullptr);
+                                              func.sig, str, str_null);
     } else {
       // Compile the function.
       code = compiler::CompileWasmFunction(thrower, isolate, &module_env, func);
       if (code.is_null()) {
-        thrower.Error("Compilation of #%d:%s failed.", index, cstr);
+        thrower.Error("Compilation of #%d:%.*s failed.", index, str.length,
+                      str.name);
         return MaybeHandle<JSObject>();
       }
       if (func.exported) {
         function = compiler::CompileJSToWasmWrapper(
             isolate, &module_env, name, code, instance.js_object, index);
       }
     }
     if (!code.is_null()) {
       // Install the code into the linker table.
       linker.Finish(index, code);
@@ skipping 21 matching lines @@
         isolate->native_context()->object_function(), isolate);
     Handle<JSObject> exports_object =
         factory->NewJSObject(object_function, TENURED);
     Handle<String> exports_name = factory->InternalizeUtf8String("exports");
     JSObject::AddProperty(instance.js_object, exports_name, exports_object,
                           READ_ONLY);
 
     // Compile wrappers and add them to the exports object.
     for (const WasmExport& exp : export_table) {
       if (thrower.error()) break;
-      const char* cstr = GetName(exp.name_offset);
-      Handle<String> name = factory->InternalizeUtf8String(cstr);
+      WasmName str = GetName(exp.name_offset, exp.name_length);
+      Handle<String> name = factory->InternalizeUtf8String(
+          Vector<const char>(str.name, str.length));
       Handle<Code> code = linker.GetFunctionCode(exp.func_index);
       Handle<JSFunction> function = compiler::CompileJSToWasmWrapper(
           isolate, &module_env, name, code, instance.js_object, exp.func_index);
       JSObject::AddProperty(exports_object, name, function, READ_ONLY);
     }
 
     if (mem_export) {
       // Export the memory as a named property.
       Handle<String> name = factory->InternalizeUtf8String("memory");
       JSObject::AddProperty(exports_object, name, instance.mem_buffer,
@@ skipping 147 matching lines @@
   }
   if (result->IsHeapNumber()) {
     return static_cast<int32_t>(HeapNumber::cast(*result)->value());
   }
   thrower.Error("WASM.compileRun() failed: Return value should be number");
   return -1;
 }
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8