Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: src/compiler/js-inlining.cc

Issue 1781303002: [turbofan] Avoid dereferencing empty handle when inlining a tail call. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-593697-2.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-inlining.cc
diff --git a/src/compiler/js-inlining.cc b/src/compiler/js-inlining.cc
index 451f3f66be556a273f6e3af2995ae01035c33b93..73aefcf14264ef6a4763e8581155a33c4a56b887 100644
--- a/src/compiler/js-inlining.cc
+++ b/src/compiler/js-inlining.cc
@@ -265,8 +265,8 @@ Node* JSInliner::CreateArtificialFrameState(Node* node, Node* outer_frame_state,
Node* JSInliner::CreateTailCallerFrameState(Node* node, Node* frame_state) {
FrameStateInfo const& frame_info = OpParameter<FrameStateInfo>(frame_state);
- Handle<SharedFunctionInfo> shared =
- frame_info.shared_info().ToHandleChecked();
+ Handle<SharedFunctionInfo> shared;
+ frame_info.shared_info().ToHandle(&shared);
Node* function = frame_state->InputAt(kFrameStateFunctionInput);
@@ -274,8 +274,8 @@ Node* JSInliner::CreateTailCallerFrameState(Node* node, Node* frame_state) {
// arguments adaptor if it exists.
frame_state = NodeProperties::GetFrameStateInput(frame_state, 0);
if (frame_state->opcode() == IrOpcode::kFrameState) {
- FrameStateInfo state_info = OpParameter<FrameStateInfo>(frame_state);
- if (state_info.type() == FrameStateType::kArgumentsAdaptor) {
+ FrameStateInfo const& frame_info = OpParameter<FrameStateInfo>(frame_state);
+ if (frame_info.type() == FrameStateType::kArgumentsAdaptor) {
frame_state = NodeProperties::GetFrameStateInput(frame_state, 0);
}
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-593697-2.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698