Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 178113003: Revert of Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper. (Closed)

Created:
6 years, 9 months ago by Dominik Grewe
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, danakj, Rik, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper. (https://codereview.chromium.org/177473003/) Reason for revert: crash in SkCanvas::getTotalMatrix (crbug.com/348122) Reverting this to see if it fixes it, otherwise we can reland. Original issue's description: > Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper. > > The addLayer() methods of SkLayerDrawLooper will soon be removed. This CL > updates all uses of those methods with the corresponding methods in > SkLayerDrawLooper::Builder. > > BUG=skia:2141 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168041 TBR=schenney@chromium.org,jbroman@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -243 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/EllipsisBox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A Source/platform/graphics/DrawLooper.h View 1 chunk +79 lines, -0 lines 0 comments Download
A Source/platform/graphics/DrawLooper.cpp View 1 chunk +104 lines, -0 lines 0 comments Download
D Source/platform/graphics/DrawLooperBuilder.h View 1 chunk +0 lines, -82 lines 0 comments Download
D Source/platform/graphics/DrawLooperBuilder.cpp View 1 chunk +0 lines, -109 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 3 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dominik Grewe
Created Revert of Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper.
6 years, 9 months ago (2014-03-01 10:02:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/178113003/1
6 years, 9 months ago (2014-03-01 10:03:09 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-01 10:03:27 UTC) #3
Message was sent while issue was closed.
Change committed as 168243

Powered by Google App Engine
This is Rietveld 408576698