Add CONTEXT_TYPE_OPENGLES2_PEPPER

Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30
Cr-Commit-Position: refs/heads/master@{#382097}

[ericrk, 2016-03-10 21:44:35]

Description was changed from

==========
Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
==========

to

==========
Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[ericrk, 2016-03-10 21:48:56]

ericrk@chromium.org changed reviewers:
+ zmo@google.com

[ericrk, 2016-03-10 21:49:22]

ericrk@chromium.org changed reviewers:
+ zmo@chromium.org
- zmo@google.com

[Zhenyao Mo, 2016-03-10 21:58:15]

lgtm

[ericrk, 2016-03-11 00:56:00]

ericrk@chromium.org changed reviewers:
+ piman@chromium.org

[ericrk, 2016-03-11 00:56:00]

+piman for PPAPI stuff.

[ericrk, 2016-03-15 22:51:55]

Description was changed from

==========
Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[ericrk, 2016-03-15 22:51:55]

ericrk@chromium.org changed reviewers:
- piman@chromium.org

[ericrk, 2016-03-15 22:52:27]

ericrk@chromium.org changed reviewers:
+ piman@chromium.org, sievers@chromium.org

[ericrk, 2016-03-15 22:52:59]

+sievers for PPAPI content stuff

[no sievers, 2016-03-16 00:46:58]

lgtm w/nit

https://codereview.chromium.org/1781093002/diff/20001/content/renderer/pepper...
File content/renderer/pepper/ppb_graphics_3d_impl.cc (right):

https://codereview.chromium.org/1781093002/diff/20001/content/renderer/pepper...
content/renderer/pepper/ppb_graphics_3d_impl.cc:49: const int32_t kContextType =
0x10003;
Can you just move it from gles2_cmd_utils.cc to .h then so we don't need to have
it matching in two places?

[ericrk, 2016-03-16 16:43:38]

Patchset #3 (id:40001) has been deleted

[ericrk, 2016-03-16 16:53:21]

https://codereview.chromium.org/1781093002/diff/20001/content/renderer/pepper...
File content/renderer/pepper/ppb_graphics_3d_impl.cc (right):

https://codereview.chromium.org/1781093002/diff/20001/content/renderer/pepper...
content/renderer/pepper/ppb_graphics_3d_impl.cc:49: const int32_t kContextType =
0x10003;
On 2016/03/16 00:46:58, sievers (slow) wrote:
> Can you just move it from gles2_cmd_utils.cc to .h then so we don't need to
have
> it matching in two places?

Done.

[ericrk, 2016-03-16 17:13:55]

Patchset #3 (id:60001) has been deleted

[piman, 2016-03-16 23:55:05]

https://codereview.chromium.org/1781093002/diff/80001/content/renderer/pepper...
File content/renderer/pepper/ppb_graphics_3d_impl.cc (right):

https://codereview.chromium.org/1781093002/diff/80001/content/renderer/pepper...
content/renderer/pepper/ppb_graphics_3d_impl.cc:265: DCHECK(false);
The attrib list comes from an untrusted side (e.g. a NaCl plugin), so you can't
DCHECK this here. You don't have to succeed if it's there, though.

[piman, 2016-03-17 00:06:29]

At a high level, this feels like a bit of a contrived way to look at the
problem. If we want to disable MSAA for the compositor & skia because it's
slower, that logic should live in the compositor/skia, rather than by
blacklisting it from the service side. We can use the GPU workarounds mechanism
to instead give a "msaa_is_slow" bit in the gpu::Capabilities returned by the
Decoder, and then the client side can decide what to do. This would also avoid
weirdness if different contexts in the same share group have different support
for MSAA.

[ericrk, 2016-03-17 17:03:31]

On 2016/03/17 00:06:29, piman wrote:
> At a high level, this feels like a bit of a contrived way to look at the
> problem. If we want to disable MSAA for the compositor & skia because it's
> slower, that logic should live in the compositor/skia, rather than by
> blacklisting it from the service side. We can use the GPU workarounds
mechanism
> to instead give a "msaa_is_slow" bit in the gpu::Capabilities returned by the
> Decoder, and then the client side can decide what to do. This would also avoid
> weirdness if different contexts in the same share group have different support
> for MSAA.

Hmm... I see what you're saying... let me think about this a bit more and
re-work things.

[ericrk, 2016-03-17 18:53:26]

Patchset #4 (id:100001) has been deleted

[ericrk, 2016-03-17 19:00:20]

Patchset #4 (id:120001) has been deleted

[ericrk, 2016-03-17 19:05:35]

Patchset #4 (id:140001) has been deleted

[ericrk, 2016-03-17 19:45:25]

Patchset #4 (id:160001) has been deleted

[ericrk, 2016-03-17 20:16:49]

Reworked things along the lines of piman's suggestion. Seems a lot nicer. Thanks
for the feedback.

[ericrk, 2016-03-17 20:17:20]

Patchset #4 (id:180001) has been deleted

[piman, 2016-03-17 23:09:47]

lgtm

https://codereview.chromium.org/1781093002/diff/200001/gpu/config/gpu_driver_...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/1781093002/diff/200001/gpu/config/gpu_driver_...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.49",
nit: bump.

[piman, 2016-03-17 23:09:47]

lgtm

lgtm

https://codereview.chromium.org/1781093002/diff/200001/gpu/config/gpu_driver_...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/1781093002/diff/200001/gpu/config/gpu_driver_...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.49",
nit: bump.

[ericrk, 2016-03-18 18:31:50]

https://codereview.chromium.org/1781093002/diff/200001/gpu/config/gpu_driver_...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/1781093002/diff/200001/gpu/config/gpu_driver_...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.49",
On 2016/03/17 23:09:47, piman wrote:
> nit: bump.

Done.

[ericrk, 2016-03-18 18:31:54]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-03-18 18:31:54]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
sievers@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1781093002/#ps240001
(title: "rev bug list json version")

[commit-bot: I haz the power, 2016-03-18 18:32:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781093002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781093002/240001

[commit-bot: I haz the power, 2016-03-18 20:34:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 20:34:31]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[ericrk, 2016-03-18 20:40:27]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2016-03-18 20:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781093002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781093002/240001

[commit-bot: I haz the power, 2016-03-18 21:44:49]

Description was changed from

==========
Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-18 21:44:51]

Committed patchset #6 (id:240001)

[commit-bot: I haz the power, 2016-03-18 21:46:10]

Description was changed from

==========
Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Add CONTEXT_TYPE_OPENGLES2_PEPPER

Adds a new context type for Pepper GL contexts. This allows us to
fine tune driver bug workarounds for pepper vs. non-pepper contexts.

Currently used to disable the Intel MSAA blacklist on pepper contexts,
as it should be up to the app whether to use MSAA.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30
Cr-Commit-Position: refs/heads/master@{#382097}
==========

[commit-bot: I haz the power, 2016-03-18 21:46:11]

Patchset 6 (id:??) landed as
https://crrev.com/d72af43d432d9def9ce591b7167c19b7b1581e30
Cr-Commit-Position: refs/heads/master@{#382097}