Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 1781093002: Add CONTEXT_TYPE_OPENGLES2_PEPPER (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rev bug list json version Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info_unittest.cc
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc
index 63d6b5f8c3fa0101e614958b4d2578a50de27086..62c3a2e0aecc8e0e7f73a7100f9cedf09edaa3c0 100644
--- a/gpu/command_buffer/service/feature_info_unittest.cc
+++ b/gpu/command_buffer/service/feature_info_unittest.cc
@@ -105,19 +105,6 @@ class FeatureInfoTest
info_->InitializeForTesting();
}
- void SetupInitExpectationsWithGLVersionAndContextTypeAndCommandLine(
- const char* extensions,
- const char* renderer,
- const char* version,
- ContextType context_type,
- const base::CommandLine& command_line) {
- GpuServiceTest::SetUpWithGLVersion(version, extensions);
- TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(
- gl_.get(), extensions, renderer, version);
- info_ = new FeatureInfo(command_line);
- info_->Initialize(context_type, DisallowedFeatures());
- }
-
void SetupWithCommandLine(const base::CommandLine& command_line) {
GpuServiceTest::SetUp();
info_ = new FeatureInfo(command_line);
@@ -1423,29 +1410,5 @@ TEST_P(FeatureInfoTest, InitializeCHROMIUM_ycbcr_422_imageTrue) {
EXPECT_TRUE(info_->feature_flags().chromium_image_ycbcr_422);
}
-TEST_P(FeatureInfoTest, DisableMsaaOnNonWebGLContexts) {
- base::CommandLine command_line(0, NULL);
- command_line.AppendSwitchASCII(
- switches::kGpuDriverBugWorkarounds,
- base::IntToString(gpu::DISABLE_MSAA_ON_NON_WEBGL_CONTEXTS));
- SetupInitExpectationsWithGLVersionAndContextTypeAndCommandLine(
- "GL_EXT_multisampled_render_to_texture GL_EXT_framebuffer_multisample",
- "", "", CONTEXT_TYPE_OPENGLES2, command_line);
- EXPECT_FALSE(info_->feature_flags().multisampled_render_to_texture);
- EXPECT_FALSE(info_->feature_flags().chromium_framebuffer_multisample);
-}
-
-TEST_P(FeatureInfoTest, DontDisableMsaaOnWebGLContexts) {
- base::CommandLine command_line(0, NULL);
- command_line.AppendSwitchASCII(
- switches::kGpuDriverBugWorkarounds,
- base::IntToString(gpu::DISABLE_MSAA_ON_NON_WEBGL_CONTEXTS));
- SetupInitExpectationsWithGLVersionAndContextTypeAndCommandLine(
- "GL_EXT_multisampled_render_to_texture GL_EXT_framebuffer_multisample",
- "", "", CONTEXT_TYPE_WEBGL1, command_line);
- EXPECT_TRUE(info_->feature_flags().multisampled_render_to_texture);
- EXPECT_TRUE(info_->feature_flags().chromium_framebuffer_multisample);
-}
-
} // namespace gles2
} // namespace gpu
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698