|
Revert of MediaStream audio object graph untangling and clean-ups. (patchset #10 id:200001 of https://codereview.chromium.org/1721273002/ )
Reason for revert:
Broke a number of mediastream/ tests, e.g., https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/9786
Original issue's description:
> MediaStream audio object graph untangling and clean-ups.
>
> This change consists of a number of "clean-up" changes that are being
> done to make the soon-upcoming refactoring of these classes go much more
> smoothly. These are:
>
> 1. Public content MediaStreamApi functions cleaned up. Removed
> "duplicated" functions that don't really do the same thing. Removed
> hard-coded audio parameters from AddAudioTrackToMediaStream().
>
> 2. Eliminated ref-counting of WebRtcAudioCapturer and
> WebAudioCaptureSource. Removed unnecessary references to these from
> WebRtcLocalAudioTrack. Not only did this improve encapsulation of some
> code, but it also allowed for the removal of several dozen lines of
> "dead weight" testing set-upcode throughout the directory.
>
> 3. Renamed MediaStreamAudioTrack::GetTrack() method to From(), to be
> consistent with how this pattern is used in other parts of libcontent,
> and added a MediaStreamAudioSource::From().
>
> 4. Moved audio level calculations out of WebRtcLocalAudioTrack and into
> WebRtcAudioCapturer. This way, when multiple tracks are present, the
> calculation is only being done once on the same audio.
>
> 5. Eliminated call to WebRtcCapturer::Stop() from
> WebRtcAudioDeviceImpl::Terminate(), which are each supposed to run on
> different threads. From testing, DCHECKs should have been firing, but
> weren't, so the Terminate() method seems to be dead code.
>
> 6. Miscellaneous other "compaction" and comment updates.
>
> BUG= 577881, 577874
> TBR=peter@chromium.org
>
> Committed: https://crrev.com/26bfd80549511a7e05f23c9941c41ced104ddf28
> Cr-Commit-Position: refs/heads/master@{#380065}
TBR=jochen@chromium.org,finnur@chromium.org,mcasas@chromium.org,olka@chromium.org,peter@chromium.org,tommi@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 577881, 577874
Committed: https://crrev.com/0a40d9db89298db3edb7cbb49488db1100e0cdbb
Cr-Commit-Position: refs/heads/master@{#380103}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+823 lines, -771 lines) |
Patch |
|
M |
chrome/renderer/extensions/cast_streaming_native_handler.cc
|
View
|
|
2 chunks |
+5 lines, -20 lines |
0 comments
|
Download
|
|
M |
content/public/renderer/media_stream_api.h
|
View
|
|
1 chunk |
+24 lines, -16 lines |
0 comments
|
Download
|
|
M |
content/public/renderer/media_stream_api.cc
|
View
|
|
2 chunks |
+84 lines, -65 lines |
0 comments
|
Download
|
|
M |
content/public/renderer/media_stream_audio_sink.cc
|
View
|
|
1 chunk |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/audio_track_recorder.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/audio_track_recorder_unittest.cc
|
View
|
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/media/media_recorder_handler.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_audio_level_calculator.h
|
View
|
|
2 chunks |
+14 lines, -35 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_audio_level_calculator.cc
|
View
|
|
4 chunks |
+12 lines, -25 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_audio_source.h
|
View
|
|
3 chunks |
+9 lines, -48 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_audio_source.cc
|
View
|
|
3 chunks |
+3 lines, -34 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_audio_track.h
|
View
|
|
4 chunks |
+2 lines, -28 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_audio_track.cc
|
View
|
|
3 chunks |
+1 line, -26 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_center.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/media_stream_renderer_factory_impl.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/mock_media_stream_registry.cc
|
View
|
|
2 chunks |
+13 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/rtc_peer_connection_handler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/media/rtc_peer_connection_handler_unittest.cc
|
View
|
|
3 chunks |
+12 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/speech_recognition_audio_sink.cc
|
View
|
|
1 chunk |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/media/speech_recognition_audio_sink_unittest.cc
|
View
|
|
3 chunks |
+13 lines, -5 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/track_audio_renderer.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/user_media_client_impl.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/media/user_media_client_impl_unittest.cc
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webaudio_capturer_source.h
|
View
|
|
4 chunks |
+18 lines, -8 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webaudio_capturer_source.cc
|
View
|
|
3 chunks |
+12 lines, -13 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/media_stream_remote_audio_track.h
|
View
|
|
3 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/media_stream_remote_audio_track.cc
|
View
|
|
2 chunks |
+3 lines, -8 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h
|
View
|
|
3 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc
|
View
|
|
3 chunks |
+11 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/peer_connection_dependency_factory.h
|
View
|
|
2 chunks |
+9 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/peer_connection_dependency_factory.cc
|
View
|
|
7 chunks |
+43 lines, -32 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/webrtc_local_audio_track_adapter.h
|
View
|
|
4 chunks |
+21 lines, -19 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc
|
View
|
|
6 chunks |
+35 lines, -42 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc
|
View
|
|
5 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/webrtc_media_stream_adapter.cc
|
View
|
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
|
View
|
|
2 chunks |
+10 lines, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_audio_capturer.h
|
View
|
|
8 chunks |
+20 lines, -14 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_audio_capturer.cc
|
View
|
|
14 chunks |
+114 lines, -54 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_audio_capturer_unittest.cc
|
View
|
|
3 chunks |
+26 lines, -25 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_audio_device_impl.h
|
View
|
|
4 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_audio_device_impl.cc
|
View
|
|
8 chunks |
+52 lines, -37 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_audio_renderer.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
|
View
|
|
2 chunks |
+11 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_local_audio_track.h
|
View
|
|
4 chunks |
+46 lines, -16 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_local_audio_track.cc
|
View
|
|
3 chunks |
+97 lines, -25 lines |
0 comments
|
Download
|
|
M |
content/renderer/media/webrtc_local_audio_track_unittest.cc
|
View
|
|
16 chunks |
+41 lines, -92 lines |
0 comments
|
Download
|
|
M |
content/renderer/renderer_blink_platform_impl.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
content/shell/renderer/layout_test/blink_test_runner.cc
|
View
|
|
2 chunks |
+2 lines, -9 lines |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|