Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1780403002: Enable Curve25519 in host and client for PIN-based and third-party auth. (Closed)

Created:
4 years, 9 months ago by Sergey Ulanov
Modified:
4 years, 9 months ago
Reviewers:
Jamie, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Curve25519 in host and client for PIN-based and third-party auth. Now client and host can use Spake2Authenticator instead of V2Authenticator for both PIN-based auth and third-party auth. The plan is to use cleanup It2Me to use hashed ID, so it will be possible to remove spake2_plain method completely, so I'm not adding Curve25519 version. Also pairing authentication needs move work to enable Curve25519 (see crbug.com/593123), so it's going to be done separately. Spake2Authenticor implements SPAKE2 over Curve25519, which is defined in https://tools.ietf.org/html/draft-irtf-cfrg-spake2-03 . BUG=589698 Committed: https://crrev.com/4357fda5f2518a8dd54121386ba0c3fbe1dc2ec0 Cr-Commit-Position: refs/heads/master@{#380869}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -73 lines) Patch
M remoting/client/chromoting_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_base.h View 1 1 chunk +19 lines, -4 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_base.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_unittest.cc View 1 10 chunks +16 lines, -13 lines 0 comments Download
M remoting/protocol/negotiating_client_authenticator.h View 2 chunks +10 lines, -6 lines 0 comments Download
M remoting/protocol/negotiating_client_authenticator.cc View 4 chunks +48 lines, -21 lines 0 comments Download
M remoting/protocol/negotiating_host_authenticator.h View 5 chunks +12 lines, -1 line 0 comments Download
M remoting/protocol/negotiating_host_authenticator.cc View 6 chunks +42 lines, -14 lines 0 comments Download
M remoting/protocol/spake2_authenticator.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/spake2_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/spake2_authenticator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
Sergey Ulanov
4 years, 9 months ago (2016-03-11 00:22:27 UTC) #3
Jamie
LGTM, but please update the CL description with a brief overview of Curve25519 and perhaps ...
4 years, 9 months ago (2016-03-11 23:06:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780403002/20001
4 years, 9 months ago (2016-03-11 23:42:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/194476)
4 years, 9 months ago (2016-03-12 00:03:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780403002/40001
4 years, 9 months ago (2016-03-12 06:31:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-12 07:23:33 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 07:24:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4357fda5f2518a8dd54121386ba0c3fbe1dc2ec0
Cr-Commit-Position: refs/heads/master@{#380869}

Powered by Google App Engine
This is Rietveld 408576698