Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: remoting/protocol/negotiating_authenticator_base.h

Issue 1780403002: Enable Curve25519 in host and client for PIN-based and third-party auth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/negotiating_authenticator_base.h
diff --git a/remoting/protocol/negotiating_authenticator_base.h b/remoting/protocol/negotiating_authenticator_base.h
index 1a43a9eccefcb788938818ae9063348868e6ac08..243359fd706ca05a67d8476063c975db40d865b6 100644
--- a/remoting/protocol/negotiating_authenticator_base.h
+++ b/remoting/protocol/negotiating_authenticator_base.h
@@ -66,10 +66,25 @@ class NegotiatingAuthenticatorBase : public Authenticator {
// Method represents an authentication algorithm.
enum class Method {
INVALID,
- SPAKE2_SHARED_SECRET_PLAIN,
- SPAKE2_SHARED_SECRET_HMAC,
- SPAKE2_PAIR,
- THIRD_PARTY,
+
+ // SPAKE2 with P224 using access code in plain-text. Used for It2Me.
+ // TODO(sergeyu): Remove and use SHARED_SECRET_SPAKE2_CURVE25519.
+ SHARED_SECRET_PLAIN_SPAKE2_P224,
+
+ // SPAKE2 PIN or access code hashed with host_id using HMAC-SHA256.
+ SHARED_SECRET_SPAKE2_P224,
+ SHARED_SECRET_SPAKE2_CURVE25519,
+
+ // SPAKE2 using shared pairing secret. Falls back to PIN-based
+ // authentication when pairing fails.
+ // TODO(sergeyu): Add CURVE25519 variant. crbug.com/593123
+ PAIRED_SPAKE2_P224,
+
+ // Authentication using third-party authentication server.
+ // SPAKE2 with P224 using shared pairing secret. Falls back to PIN-based
+ // authentication when it fails to authenticate using paired secret.
+ THIRD_PARTY_SPAKE2_P224,
+ THIRD_PARTY_SPAKE2_CURVE25519,
};
~NegotiatingAuthenticatorBase() override;
« no previous file with comments | « remoting/protocol/me2me_host_authenticator_factory.cc ('k') | remoting/protocol/negotiating_authenticator_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698