Move NegotiatingClientAuthentication creation to ChromotingClient.

Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698
Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}

Committed: https://crrev.com/396d93351822bf9c6bb4ad909919d46f98ceaaa8
Cr-Commit-Position: refs/heads/master@{#380831}

[Sergey Ulanov, 2016-03-10 02:11:41]

Description was changed from

==========
Move NegotiatingCleintAuthentication to ChromotingClient.



BUG=
==========

to

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698
==========

[Sergey Ulanov, 2016-03-10 02:11:52]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2016-03-10 02:13:01]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-03-11 18:17:40]

lgtm

[Sergey Ulanov, 2016-03-11 18:39:53]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-03-11 18:40:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778023002/20001

[Sergey Ulanov, 2016-03-11 19:08:13]

The CQ bit was unchecked by sergeyu@chromium.org

[Sergey Ulanov, 2016-03-11 19:08:41]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-03-11 19:09:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778023002/20001

[commit-bot: I haz the power, 2016-03-11 19:23:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 19:23:09]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Sergey Ulanov, 2016-03-11 19:30:35]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-03-11 19:30:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1778023002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-03-11 19:31:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778023002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778023002/40001

[commit-bot: I haz the power, 2016-03-11 20:45:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 20:45:37]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2016-03-11 22:38:32]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-03-11 22:39:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778023002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778023002/40001

[commit-bot: I haz the power, 2016-03-11 23:17:45]

Description was changed from

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698
==========

to

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698
==========

[commit-bot: I haz the power, 2016-03-11 23:17:46]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-11 23:19:06]

Description was changed from

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698
==========

to

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698

Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
==========

[commit-bot: I haz the power, 2016-03-11 23:19:07]

Patchset 2 (id:??) landed as
https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}

[alexmos, 2016-03-11 23:45:29]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1788943002/ by alexmos@chromium.org.

The reason for reverting is: Appears to be breaking compile on Linux and Mac:
https://build.chromium.org/p/chromium/builders/Linux/builds/72875

https://build.chromium.org/p/chromium/builders/Mac/builds/13060

Output:

FAILED: /b/build/slave/Linux/build/src/build/goma/client/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ ... -c
../../remoting/test/chromoting_test_fixture.cc -o
obj/remoting/test/chromoting_test_driver.chromoting_test_fixture.o
In file included from ../../remoting/test/chromoting_test_fixture.cc:14:
In file included from ../../remoting/test/test_chromoting_client.h:14:
In file included from ../../remoting/client/chromoting_client.h:19:
In file included from
../../remoting/protocol/negotiating_client_authenticator.h:15:
In file included from
../../remoting/protocol/negotiating_authenticator_base.h:16:
../../third_party/webrtc/libjingle/xmllite/xmlelement.h:17:10: fatal error:
'webrtc/libjingle/xmllite/qname.h' file not found
#include "webrtc/libjingle/xmllite/qname.h"
         ^
1 error generated.
ninja: build stopped: subcommand failed..

[Sergey Ulanov, 2016-03-12 00:59:52]

Description was changed from

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698

Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
==========

to

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698

Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
==========

[Sergey Ulanov, 2016-03-12 01:01:48]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-03-12 01:01:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1778023002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-12 01:02:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1778023002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1778023002/60001

[commit-bot: I haz the power, 2016-03-12 01:59:06]

Description was changed from

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698

Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
==========

to

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698

Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
==========

[commit-bot: I haz the power, 2016-03-12 01:59:07]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-12 02:00:02]

Description was changed from

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698

Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
==========

to

==========
Move NegotiatingClientAuthentication creation to ChromotingClient.

For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.

BUG=589698

Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}

Committed: https://crrev.com/396d93351822bf9c6bb4ad909919d46f98ceaaa8
Cr-Commit-Position: refs/heads/master@{#380831}
==========

[commit-bot: I haz the power, 2016-03-12 02:00:03]

Patchset 3 (id:??) landed as
https://crrev.com/396d93351822bf9c6bb4ad909919d46f98ceaaa8
Cr-Commit-Position: refs/heads/master@{#380831}