Issue 178003008: Remove the HTMLVideoElement-specific prefixed fullscreen API

Issue 178003008: Remove the HTMLVideoElement-specific prefixed fullscreen API (Closed)

Created:
6 years, 10 months ago by philipj_slow

Modified:
6 years, 10 months ago

Reviewers:
tkent, acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, arv+blink, philipj_slow, gasubic, fs, eric.carlson_apple.com, watchdog-blink-watchlist_google.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove the HTMLVideoElement-specific prefixed fullscreen API Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Bxe7DnDVRZ0/5K61HQPrNK4J BUG=346236 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167815

Patch Set 1 #

Total comments: 3

Patch Set 2 : rm negative test #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -135 lines)			Patch
M	LayoutTests/fullscreen/full-screen-iframe-legacy.html	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	LayoutTests/media/video-controls-visible-exiting-fullscreen.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/media/video-controls-visible-exiting-fullscreen-expected.txt	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	LayoutTests/media/video-enter-fullscreen-without-user-gesture.html	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/media/video-enter-fullscreen-without-user-gesture-expected.txt	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	LayoutTests/media/video-play-require-user-gesture.html	View		4 chunks	+2 lines, -11 lines	0 comments	Download
M	LayoutTests/media/video-play-require-user-gesture-expected.txt	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	Source/core/frame/UseCounter.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.h	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.cpp	View		2 chunks	+0 lines, -46 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.idl	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Requesting IDL review from tkent, everything else from acolwell.

6 years, 10 months ago (2014-02-25 06:01:02 UTC) #1

philipj_slow

https://codereview.chromium.org/178003008/diff/1/Source/core/html/HTMLMediaElement.h File Source/core/html/HTMLMediaElement.h (left): https://codereview.chromium.org/178003008/diff/1/Source/core/html/HTMLMediaElement.h#oldcode305 Source/core/html/HTMLMediaElement.h:305: RequireUserGestureForPlayRestriction = 1 << 0, Yes, this is a ...

6 years, 10 months ago (2014-02-25 06:02:15 UTC) #2

acolwell GONE FROM CHROMIUM

lgtm % comment. https://codereview.chromium.org/178003008/diff/1/LayoutTests/media/video-prefixed-fullscreen.html File LayoutTests/media/video-prefixed-fullscreen.html (right): https://codereview.chromium.org/178003008/diff/1/LayoutTests/media/video-prefixed-fullscreen.html#newcode19 LayoutTests/media/video-prefixed-fullscreen.html:19: t('webkitSupportsFullscreen'); Why create a test that ...

6 years, 10 months ago (2014-02-25 17:37:42 UTC) #4

philipj_slow

https://codereview.chromium.org/178003008/diff/1/LayoutTests/media/video-prefixed-fullscreen.html File LayoutTests/media/video-prefixed-fullscreen.html (right): https://codereview.chromium.org/178003008/diff/1/LayoutTests/media/video-prefixed-fullscreen.html#newcode19 LayoutTests/media/video-prefixed-fullscreen.html:19: t('webkitSupportsFullscreen'); On 2014/02/25 17:37:43, acolwell wrote: > Why create ...

6 years, 10 months ago (2014-02-25 18:00:38 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/178003008/20001

6 years, 10 months ago (2014-02-25 18:03:20 UTC) #7

Message was sent while issue was closed.

Change committed as 167815

Expand Messages | Collapse Messages