Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 177123006: Reduce HTMLMediaElement BehaviorRestrictions to a single state bit (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Reduce HTMLMediaElement BehaviorRestrictions to a single state bit There's only a single restriction left, so make it more obvious. Although not the main purpose, this reduces sizeof(HTMLMediaElement) by 4 bytes, from 584 to 580 on Mac Debug. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -31 lines) Patch
M Source/core/html/HTMLMediaElement.h View 4 chunks +1 line, -16 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 8 chunks +8 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
Depends on https://codereview.chromium.org/178003008/
6 years, 10 months ago (2014-02-25 18:04:15 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 10 months ago (2014-02-25 18:09:52 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-25 22:01:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/177123006/1
6 years, 10 months ago (2014-02-25 22:01:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/177123006/1
6 years, 10 months ago (2014-02-25 23:09:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/177123006/1
6 years, 10 months ago (2014-02-25 23:27:58 UTC) #6
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:45:23 UTC) #7
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 06:01:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/177123006/1
6 years, 10 months ago (2014-02-26 06:06:58 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 08:53:00 UTC) #10
Message was sent while issue was closed.
Change committed as 167864

Powered by Google App Engine
This is Rietveld 408576698