Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1779683002: Add catalog unittests (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@43catalog
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add catalog unittests. - Decompose the catalog into various files. TBR=sky@chromium.org BUG= Committed: https://crrev.com/a6d912093a6d1123c1d8dfb3a0ca3802d03a0f2d Cr-Commit-Position: refs/heads/master@{#380093}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -146 lines) Patch
M mojo/mojo_shell.gyp View 1 chunk +8 lines, -2 lines 0 comments Download
M mojo/services/catalog/BUILD.gn View 1 2 3 chunks +21 lines, -0 lines 0 comments Download
A mojo/services/catalog/builder.h View 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/services/catalog/builder.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
A mojo/services/catalog/builder_unittest.cc View 1 2 3 1 chunk +89 lines, -0 lines 0 comments Download
M mojo/services/catalog/catalog.h View 4 chunks +7 lines, -49 lines 0 comments Download
M mojo/services/catalog/catalog.cc View 8 chunks +30 lines, -94 lines 0 comments Download
A mojo/services/catalog/data/capabilities View 1 1 chunk +8 lines, -0 lines 0 comments Download
A mojo/services/catalog/data/instance View 1 1 chunk +6 lines, -0 lines 0 comments Download
A mojo/services/catalog/data/malformed View 1 1 chunk +4 lines, -0 lines 0 comments Download
A mojo/services/catalog/data/simple View 1 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/services/catalog/entry.h View 1 chunk +34 lines, -0 lines 0 comments Download
A mojo/services/catalog/entry.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M mojo/services/catalog/loader.h View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/services/catalog/store.h View 1 chunk +42 lines, -0 lines 0 comments Download
A mojo/services/catalog/store.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M mojo/shell/background/tests/test_catalog_store.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1775243002 Patch 20001

Dependent Patchsets:

Issue 1775113003 Patch 1
Issue 1775113003 Patch 20001
Issue 1775113003 Patch 40001
Issue 1775113003 Patch 60001
Issue 1775113003 Patch 80001
Issue 1775113003 Patch 100001
Issue 1775113003 Patch 120001
Issue 1775113003 Patch 140001

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779683002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779683002/60001
4 years, 9 months ago (2016-03-09 06:46:19 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-09 06:51:01 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 06:51:56 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a6d912093a6d1123c1d8dfb3a0ca3802d03a0f2d
Cr-Commit-Position: refs/heads/master@{#380093}

Powered by Google App Engine
This is Rietveld 408576698