Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775243002: Rename PackageManager->Catalog. (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@42cpi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PackageManager->Catalog. TBR=sky@chromium.org BUG= Committed: https://crrev.com/c18f9cc14a916cf131b6cb8f001e469d0a26de43 Cr-Commit-Position: refs/heads/master@{#380062}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -1081 lines) Patch
M mash/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M mojo/mojo_base.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/catalog/BUILD.gn View 1 1 chunk +10 lines, -19 lines 0 comments Download
A + mojo/services/catalog/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/catalog/catalog.h View 7 chunks +22 lines, -23 lines 0 comments Download
A + mojo/services/catalog/catalog.cc View 16 chunks +60 lines, -68 lines 0 comments Download
A + mojo/services/catalog/loader.h View 3 chunks +8 lines, -9 lines 0 comments Download
A + mojo/services/catalog/loader.cc View 1 chunk +7 lines, -9 lines 0 comments Download
A mojo/services/catalog/manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
A + mojo/services/catalog/public/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/catalog/public/interfaces/catalog.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/catalog/public/interfaces/resolver.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/package_manager/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/services/package_manager/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D mojo/services/package_manager/loader.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/services/package_manager/loader.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/services/package_manager/main.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D mojo/services/package_manager/manifest.json View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/services/package_manager/package_manager.h View 1 chunk +0 lines, -181 lines 0 comments Download
D mojo/services/package_manager/package_manager.cc View 1 chunk +0 lines, -356 lines 0 comments Download
D mojo/services/package_manager/public/interfaces/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/services/package_manager/public/interfaces/catalog.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/services/package_manager/public/interfaces/resolver.mojom View 1 chunk +0 lines, -29 lines 0 comments Download
M mojo/shell/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/background/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/background/background_shell.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/background/background_shell.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/background/tests/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/background/tests/background_shell_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
D mojo/shell/background/tests/test_application_catalog_store.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/shell/background/tests/test_application_catalog_store.cc View 1 chunk +0 lines, -44 lines 0 comments Download
A + mojo/shell/background/tests/test_catalog_store.h View 3 chunks +8 lines, -9 lines 0 comments Download
A + mojo/shell/background/tests/test_catalog_store.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M mojo/shell/shell.h View 4 chunks +4 lines, -5 lines 0 comments Download
M mojo/shell/shell.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M mojo/shell/standalone/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/standalone/context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/tests/loader_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/platform_test_helper_mus.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Dependent Patchsets:

Issue 1779683002 Patch 1
Issue 1779683002 Patch 20001
Issue 1779683002 Patch 40001
Issue 1779683002 Patch 60001

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775243002/20001
4 years, 9 months ago (2016-03-09 02:52:51 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 04:08:26 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 04:09:18 UTC) #5
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c18f9cc14a916cf131b6cb8f001e469d0a26de43
Cr-Commit-Position: refs/heads/master@{#380062}

Powered by Google App Engine
This is Rietveld 408576698