Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775113003: Morph CapabilityFilter into caps::Capabilities, which supports capability classes (yet unimplemente… (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@44cattests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Morph CapabilityFilter into caps::Capabilities, which supports capability classes (yet unimplemented). R=sky@chromium.org BUG= Committed: https://crrev.com/d1faec7945458e2500203bd9a7d37cd462646447 Cr-Commit-Position: refs/heads/master@{#380285}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 7

Patch Set 7 : . #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -156 lines) Patch
M mojo/mojo_base.gyp View 1 2 3 4 5 6 7 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/catalog/builder.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/catalog/builder.cc View 1 2 3 4 5 6 2 chunks +120 lines, -20 lines 0 comments Download
M mojo/services/catalog/builder_unittest.cc View 1 2 3 4 5 6 4 chunks +36 lines, -19 lines 0 comments Download
M mojo/services/catalog/catalog.cc View 1 2 3 4 5 6 2 chunks +6 lines, -15 lines 0 comments Download
A mojo/services/catalog/data/serialization View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
M mojo/services/catalog/entry.h View 1 2 3 4 5 6 2 chunks +5 lines, -9 lines 0 comments Download
M mojo/services/catalog/entry.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/services/catalog/store.h View 1 chunk +11 lines, -2 lines 0 comments Download
M mojo/services/catalog/store.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A mojo/shell/public/cpp/capabilities.h View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A mojo/shell/public/cpp/lib/capabilities.cc View 1 2 3 4 5 6 1 chunk +70 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_connection.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/shell/public/interfaces/capabilities.mojom View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/public/interfaces/shell_client.mojom View 1 2 chunks +2 lines, -1 line 0 comments Download
M mojo/shell/public/interfaces/shell_resolver.mojom View 1 2 chunks +2 lines, -14 lines 0 comments Download
M mojo/shell/shell.h View 1 2 3 4 5 6 4 chunks +4 lines, -26 lines 0 comments Download
M mojo/shell/shell.cc View 1 2 3 4 5 6 13 chunks +44 lines, -43 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app_manifest.json View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1779683002 Patch 60001

Dependent Patchsets:

Issue 1781913003 Patch 1
Issue 1781913003 Patch 20001

Messages

Total messages: 14 (5 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-09 21:04:20 UTC) #1
sky
https://codereview.chromium.org/1775113003/diff/100001/mojo/services/catalog/builder.cc File mojo/services/catalog/builder.cc (right): https://codereview.chromium.org/1775113003/diff/100001/mojo/services/catalog/builder.cc#newcode147 mojo/services/catalog/builder.cc:147: base::DictionaryValue* request = new base::DictionaryValue; scoped_ptr<base::DictionaryValue> https://codereview.chromium.org/1775113003/diff/100001/mojo/services/catalog/builder_unittest.cc File mojo/services/catalog/builder_unittest.cc ...
4 years, 9 months ago (2016-03-09 21:33:16 UTC) #2
Ben Goodger (Google)
Updated PTAL
4 years, 9 months ago (2016-03-09 22:43:59 UTC) #3
sky
LGTM
4 years, 9 months ago (2016-03-09 22:46:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775113003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775113003/120001
4 years, 9 months ago (2016-03-09 22:47:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/33667) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-09 22:57:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775113003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775113003/140001
4 years, 9 months ago (2016-03-09 23:03:07 UTC) #11
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 9 months ago (2016-03-10 01:22:06 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 01:23:53 UTC) #14
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/d1faec7945458e2500203bd9a7d37cd462646447
Cr-Commit-Position: refs/heads/master@{#380285}

Powered by Google App Engine
This is Rietveld 408576698