Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2648)

Unified Diff: blimp/common/proto/blimp_conversions.cc

Issue 1779673003: Added network components for blimp text input feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added proto coverters for TextInputType Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/proto/blimp_conversions.cc
diff --git a/blimp/common/proto/blimp_conversions.cc b/blimp/common/proto/blimp_conversions.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bb6ccaa3bfbcdf5034ead59651de03564d12b8d5
--- /dev/null
+++ b/blimp/common/proto/blimp_conversions.cc
@@ -0,0 +1,85 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/common/proto/blimp_conversions.h"
+
+namespace blimp {
+
+ui::TextInputType TextInputTypeFromProto(ImeMessage_InputType type) {
+ switch (type) {
+ case ImeMessage_InputType_TEXT:
+ return ui::TEXT_INPUT_TYPE_TEXT;
+ case ImeMessage_InputType_PASSWORD:
+ return ui::TEXT_INPUT_TYPE_PASSWORD;
+ case ImeMessage_InputType_SEARCH:
+ return ui::TEXT_INPUT_TYPE_SEARCH;
+ case ImeMessage_InputType_EMAIL:
+ return ui::TEXT_INPUT_TYPE_EMAIL;
+ case ImeMessage_InputType_NUMBER:
+ return ui::TEXT_INPUT_TYPE_NUMBER;
+ case ImeMessage_InputType_TELEPHONE:
+ return ui::TEXT_INPUT_TYPE_TELEPHONE;
+ case ImeMessage_InputType_URL:
+ return ui::TEXT_INPUT_TYPE_URL;
+ case ImeMessage_InputType_DATE:
+ return ui::TEXT_INPUT_TYPE_DATE;
+ case ImeMessage_InputType_DATE_TIME:
+ return ui::TEXT_INPUT_TYPE_DATE_TIME;
+ case ImeMessage_InputType_DATE_TIME_LOCAL:
+ return ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL;
+ case ImeMessage_InputType_MONTH:
+ return ui::TEXT_INPUT_TYPE_MONTH;
+ case ImeMessage_InputType_TIME:
+ return ui::TEXT_INPUT_TYPE_TIME;
+ case ImeMessage_InputType_WEEK:
+ return ui::TEXT_INPUT_TYPE_WEEK;
+ case ImeMessage_InputType_TEXT_AREA:
+ return ui::TEXT_INPUT_TYPE_TEXT_AREA;
+ case ImeMessage_InputType_CONTENT_EDITABLE:
+ return ui::TEXT_INPUT_TYPE_CONTENT_EDITABLE;
+ case ImeMessage_InputType_DATE_TIME_FIELD:
+ return ui::TEXT_INPUT_TYPE_DATE_TIME_FIELD;
+ }
David Trainor- moved to gerrit 2016/03/17 21:53:29 What about unknown? What happens if the client an
+}
+
+ImeMessage_InputType TextInputTypeToProto(ui::TextInputType type) {
+ switch (type) {
+ case ui::TEXT_INPUT_TYPE_TEXT:
+ return ImeMessage_InputType_TEXT;
+ case ui::TEXT_INPUT_TYPE_PASSWORD:
+ return ImeMessage_InputType_PASSWORD;
+ case ui::TEXT_INPUT_TYPE_SEARCH:
+ return ImeMessage_InputType_SEARCH;
+ case ui::TEXT_INPUT_TYPE_EMAIL:
+ return ImeMessage_InputType_EMAIL;
+ case ui::TEXT_INPUT_TYPE_NUMBER:
+ return ImeMessage_InputType_NUMBER;
+ case ui::TEXT_INPUT_TYPE_TELEPHONE:
+ return ImeMessage_InputType_TELEPHONE;
+ case ui::TEXT_INPUT_TYPE_URL:
+ return ImeMessage_InputType_URL;
+ case ui::TEXT_INPUT_TYPE_DATE:
+ return ImeMessage_InputType_DATE;
+ case ui::TEXT_INPUT_TYPE_DATE_TIME:
+ return ImeMessage_InputType_DATE_TIME;
+ case ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL:
+ return ImeMessage_InputType_DATE_TIME_LOCAL;
+ case ui::TEXT_INPUT_TYPE_MONTH:
+ return ImeMessage_InputType_MONTH;
+ case ui::TEXT_INPUT_TYPE_TIME:
+ return ImeMessage_InputType_TIME;
+ case ui::TEXT_INPUT_TYPE_WEEK:
+ return ImeMessage_InputType_WEEK;
+ case ui::TEXT_INPUT_TYPE_TEXT_AREA:
+ return ImeMessage_InputType_TEXT_AREA;
+ case ui::TEXT_INPUT_TYPE_CONTENT_EDITABLE:
+ return ImeMessage_InputType_CONTENT_EDITABLE;
+ case ui::TEXT_INPUT_TYPE_DATE_TIME_FIELD:
+ return ImeMessage_InputType_DATE_TIME_FIELD;
+ default:
Khushal 2016/03/17 10:02:45 Why add default here? The good thing about handlin
shaktisahu 2016/03/18 19:08:05 Done.
+ return ImeMessage_InputType_TEXT;
haibinlu 2016/03/17 18:59:46 second this. consider using NOTREACHED() << "Unkno
shaktisahu 2016/03/18 19:08:05 Done.
shaktisahu 2016/03/18 19:08:05 Done.
+ }
+}
+
+} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698