Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: blimp/common/proto/blimp_conversions.cc

Issue 1779673003: Added network components for blimp text input feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added proto coverters for TextInputType Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "blimp/common/proto/blimp_conversions.h"
6
7 namespace blimp {
8
9 ui::TextInputType TextInputTypeFromProto(ImeMessage_InputType type) {
10 switch (type) {
11 case ImeMessage_InputType_TEXT:
12 return ui::TEXT_INPUT_TYPE_TEXT;
13 case ImeMessage_InputType_PASSWORD:
14 return ui::TEXT_INPUT_TYPE_PASSWORD;
15 case ImeMessage_InputType_SEARCH:
16 return ui::TEXT_INPUT_TYPE_SEARCH;
17 case ImeMessage_InputType_EMAIL:
18 return ui::TEXT_INPUT_TYPE_EMAIL;
19 case ImeMessage_InputType_NUMBER:
20 return ui::TEXT_INPUT_TYPE_NUMBER;
21 case ImeMessage_InputType_TELEPHONE:
22 return ui::TEXT_INPUT_TYPE_TELEPHONE;
23 case ImeMessage_InputType_URL:
24 return ui::TEXT_INPUT_TYPE_URL;
25 case ImeMessage_InputType_DATE:
26 return ui::TEXT_INPUT_TYPE_DATE;
27 case ImeMessage_InputType_DATE_TIME:
28 return ui::TEXT_INPUT_TYPE_DATE_TIME;
29 case ImeMessage_InputType_DATE_TIME_LOCAL:
30 return ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL;
31 case ImeMessage_InputType_MONTH:
32 return ui::TEXT_INPUT_TYPE_MONTH;
33 case ImeMessage_InputType_TIME:
34 return ui::TEXT_INPUT_TYPE_TIME;
35 case ImeMessage_InputType_WEEK:
36 return ui::TEXT_INPUT_TYPE_WEEK;
37 case ImeMessage_InputType_TEXT_AREA:
38 return ui::TEXT_INPUT_TYPE_TEXT_AREA;
39 case ImeMessage_InputType_CONTENT_EDITABLE:
40 return ui::TEXT_INPUT_TYPE_CONTENT_EDITABLE;
41 case ImeMessage_InputType_DATE_TIME_FIELD:
42 return ui::TEXT_INPUT_TYPE_DATE_TIME_FIELD;
43 }
David Trainor- moved to gerrit 2016/03/17 21:53:29 What about unknown? What happens if the client an
44 }
45
46 ImeMessage_InputType TextInputTypeToProto(ui::TextInputType type) {
47 switch (type) {
48 case ui::TEXT_INPUT_TYPE_TEXT:
49 return ImeMessage_InputType_TEXT;
50 case ui::TEXT_INPUT_TYPE_PASSWORD:
51 return ImeMessage_InputType_PASSWORD;
52 case ui::TEXT_INPUT_TYPE_SEARCH:
53 return ImeMessage_InputType_SEARCH;
54 case ui::TEXT_INPUT_TYPE_EMAIL:
55 return ImeMessage_InputType_EMAIL;
56 case ui::TEXT_INPUT_TYPE_NUMBER:
57 return ImeMessage_InputType_NUMBER;
58 case ui::TEXT_INPUT_TYPE_TELEPHONE:
59 return ImeMessage_InputType_TELEPHONE;
60 case ui::TEXT_INPUT_TYPE_URL:
61 return ImeMessage_InputType_URL;
62 case ui::TEXT_INPUT_TYPE_DATE:
63 return ImeMessage_InputType_DATE;
64 case ui::TEXT_INPUT_TYPE_DATE_TIME:
65 return ImeMessage_InputType_DATE_TIME;
66 case ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL:
67 return ImeMessage_InputType_DATE_TIME_LOCAL;
68 case ui::TEXT_INPUT_TYPE_MONTH:
69 return ImeMessage_InputType_MONTH;
70 case ui::TEXT_INPUT_TYPE_TIME:
71 return ImeMessage_InputType_TIME;
72 case ui::TEXT_INPUT_TYPE_WEEK:
73 return ImeMessage_InputType_WEEK;
74 case ui::TEXT_INPUT_TYPE_TEXT_AREA:
75 return ImeMessage_InputType_TEXT_AREA;
76 case ui::TEXT_INPUT_TYPE_CONTENT_EDITABLE:
77 return ImeMessage_InputType_CONTENT_EDITABLE;
78 case ui::TEXT_INPUT_TYPE_DATE_TIME_FIELD:
79 return ImeMessage_InputType_DATE_TIME_FIELD;
80 default:
Khushal 2016/03/17 10:02:45 Why add default here? The good thing about handlin
shaktisahu 2016/03/18 19:08:05 Done.
81 return ImeMessage_InputType_TEXT;
haibinlu 2016/03/17 18:59:46 second this. consider using NOTREACHED() << "Unkno
shaktisahu 2016/03/18 19:08:05 Done.
shaktisahu 2016/03/18 19:08:05 Done.
82 }
83 }
84
85 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698