Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: blimp/common/proto/blimp_conversions.h

Issue 1779673003: Added network components for blimp text input feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added proto coverters for TextInputType Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/proto/blimp_conversions.h
diff --git a/blimp/common/proto/blimp_conversions.h b/blimp/common/proto/blimp_conversions.h
new file mode 100644
index 0000000000000000000000000000000000000000..47ca79fee4b641dfaf67df0678d74b1eb1f07b67
--- /dev/null
+++ b/blimp/common/proto/blimp_conversions.h
@@ -0,0 +1,22 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_COMMON_PROTO_BLIMP_CONVERSIONS_H_
haibinlu 2016/03/17 18:59:46 we have a blimp/net/input_message_converter.h. Can
shaktisahu 2016/03/18 19:08:06 Done.
+#define BLIMP_COMMON_PROTO_BLIMP_CONVERSIONS_H_
+
+#include "blimp/common/blimp_common_export.h"
+#include "blimp/common/proto/ime.pb.h"
+#include "ui/base/ime/text_input_type.h"
+
+namespace blimp {
+
+BLIMP_COMMON_EXPORT ui::TextInputType TextInputTypeFromProto(
Khushal 2016/03/17 10:02:45 Could you add unit tests for these? You can take a
shaktisahu 2016/03/18 19:08:05 Done.
+ ImeMessage_InputType type);
+
+BLIMP_COMMON_EXPORT ImeMessage_InputType
+TextInputTypeToProto(ui::TextInputType type);
+
+} // namespace blimp
+
+#endif // BLIMP_COMMON_PROTO_BLIMP_CONVERSIONS_H_

Powered by Google App Engine
This is Rietveld 408576698