Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1779343002: [Extensions] Update installed bubble for extensions with synthesized actions (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update installed bubble for extensions with synthesized actions Extensions with synthesized actions shouldn't get the "How to use" text. BUG=592106 Review URL: https://codereview.chromium.org/1778603003 Cr-Commit-Position: refs/heads/master@{#380161} (cherry picked from commit 0a95746da777d05038504582018366c4738c5ae7) Committed: https://chromium.googlesource.com/chromium/src/+/1d4995584e3203ae57a7010dc584fedc84fffe8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -6 lines) Patch
M chrome/browser/ui/extensions/extension_installed_bubble.cc View 2 chunks +9 lines, -3 lines 0 comments Download
A chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/extension_action_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 9 months ago (2016-03-10 21:47:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d4995584e3203ae57a7010dc584fedc84fffe8e.

Powered by Google App Engine
This is Rietveld 408576698