[Extensions] Update installed bubble for extensions with synthesized actions

chrome/browser/ui/extensions/extension_installed_bubble.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/extension_installed_bubble.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 232 matching lines @@
   if (message_id == 0)
     return base::string16();
   return extra.empty() ? l10n_util::GetStringUTF16(message_id) :
       l10n_util::GetStringFUTF16(message_id, extra);
 }
 
 void ExtensionInstalledBubble::Initialize() {
   bool extension_action_redesign_on =
       extensions::FeatureSwitch::extension_action_redesign()->IsEnabled();
 
-  if (extensions::ActionInfo::GetBrowserActionInfo(extension_)) {
+  const extensions::ActionInfo* action_info = nullptr;
+  if ((action_info = extensions::ActionInfo::GetBrowserActionInfo(
+           extension_)) != nullptr) {
     type_ = BROWSER_ACTION;
-  } else if (extensions::ActionInfo::GetPageActionInfo(extension_) &&
+  } else if ((action_info = extensions::ActionInfo::GetPageActionInfo(
+                  extension_)) != nullptr &&
              (extensions::ActionInfo::IsVerboseInstallMessage(extension_) ||
               extension_action_redesign_on)) {
     type_ = PAGE_ACTION;
   } else if (!extensions::OmniboxInfo::GetKeyword(extension_).empty()) {
     type_ = OMNIBOX_KEYWORD;
   } else {
     type_ = GENERIC;
   }
 
   action_command_ = GetCommand(extension_->id(), browser_->profile(), type_);
   if (extensions::sync_helper::IsSyncable(extension_) &&
       SyncPromoUI::ShouldShowSyncPromo(browser_->profile()))
     options_ |= SIGN_IN_PROMO;
 
   // Determine the bubble options we want, based on the extension type.
   switch (type_) {
     case BROWSER_ACTION:
     case PAGE_ACTION:
-      options_ |= HOW_TO_USE;
+      DCHECK(action_info);
+      if (!action_info->synthesized)
+        options_ |= HOW_TO_USE;
+
       if (has_command_keybinding()) {
         options_ |= SHOW_KEYBINDING;
       } else {
         // The How-To-Use text makes the bubble seem a little crowded when the
         // extension has a keybinding, so the How-To-Manage text is not shown
         // in those cases.
         options_ |= HOW_TO_MANAGE;
       }
 
       if (type_ == BROWSER_ACTION || extension_action_redesign_on) {
         // If the toolbar redesign is enabled, all bubbles for extensions point
         // to their toolbar action.
         anchor_position_ = ANCHOR_BROWSER_ACTION;
       } else {
         DCHECK_EQ(type_, PAGE_ACTION);
         anchor_position_ = ANCHOR_PAGE_ACTION;
       }
       break;
     case OMNIBOX_KEYWORD:
       options_ |= HOW_TO_USE | HOW_TO_MANAGE;
       anchor_position_ = ANCHOR_OMNIBOX;
       break;
     case GENERIC:
       anchor_position_ = ANCHOR_APP_MENU;
       break;
   }
 }