Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1778603003: [Extensions] Update installed bubble for extensions with synthesized actions (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Update installed bubble for extensions with synthesized actions Extensions with synthesized actions shouldn't get the "How to use" text. BUG=592106 Committed: https://crrev.com/0a95746da777d05038504582018366c4738c5ae7 Cr-Commit-Position: refs/heads/master@{#380161}

Patch Set 1 #

Patch Set 2 : Win fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -6 lines) Patch
M chrome/browser/ui/extensions/extension_installed_bubble.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download
A chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/extension_action_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Devlin
4 years, 9 months ago (2016-03-09 00:10:02 UTC) #2
asargent_no_longer_on_chrome
lgtm
4 years, 9 months ago (2016-03-09 01:04:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778603003/1
4 years, 9 months ago (2016-03-09 01:20:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/179845)
4 years, 9 months ago (2016-03-09 02:08:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778603003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778603003/40001
4 years, 9 months ago (2016-03-09 18:19:50 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-09 18:33:06 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:34:49 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0a95746da777d05038504582018366c4738c5ae7
Cr-Commit-Position: refs/heads/master@{#380161}

Powered by Google App Engine
This is Rietveld 408576698