Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1779033003: DevTools: always use 16bit strings for inspector protocol. (Closed)

Created:
4 years, 9 months ago by pfeldman
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-events_chromium.org, eae+blinkwatch, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: always use 16bit strings for inspector protocol. BUG=580337 Committed: https://crrev.com/7d5643a67249ecead4ec57c5575f7907a89d7025 Cr-Commit-Position: refs/heads/master@{#380801}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -290 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-multiple-style-texts-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-eval-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 2 3 chunks +16 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp View 16 chunks +24 lines, -88 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp View 6 chunks +4 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h View 1 2 2 chunks +21 lines, -58 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/String16WTF.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 1 2 3 4 5 6 6 chunks +24 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 2 3 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8EventListenerInfo.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779033003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779033003/40001
4 years, 9 months ago (2016-03-10 05:30:10 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 07:32:22 UTC) #4
pfeldman
4 years, 9 months ago (2016-03-10 18:37:25 UTC) #6
dgozman
https://codereview.chromium.org/1779033003/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp (right): https://codereview.chromium.org/1779033003/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp#newcode57 third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp:57: m_strings.resize(offset + length + 1); This call invalidates previously ...
4 years, 9 months ago (2016-03-10 18:59:48 UTC) #7
pfeldman
All done. https://codereview.chromium.org/1779033003/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp (right): https://codereview.chromium.org/1779033003/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp#newcode253 third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:253: protocol::Vector<String16> types; On 2016/03/10 18:59:47, dgozman wrote: ...
4 years, 9 months ago (2016-03-10 23:30:10 UTC) #8
dgozman
lgtm
4 years, 9 months ago (2016-03-10 23:34:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779033003/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779033003/90001
4 years, 9 months ago (2016-03-10 23:56:56 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/179811)
4 years, 9 months ago (2016-03-11 00:41:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779033003/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779033003/110001
4 years, 9 months ago (2016-03-11 22:40:43 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/3774) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-11 22:43:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779033003/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779033003/130001
4 years, 9 months ago (2016-03-11 22:46:53 UTC) #22
commit-bot: I haz the power
Committed patchset #8 (id:130001)
4 years, 9 months ago (2016-03-12 00:26:16 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 00:27:43 UTC) #25
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/7d5643a67249ecead4ec57c5575f7907a89d7025
Cr-Commit-Position: refs/heads/master@{#380801}

Powered by Google App Engine
This is Rietveld 408576698