third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp - Issue 1779033003: DevTools: always use 16bit strings for inspector protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

Issue 1779033003: DevTools: always use 16bit strings for inspector protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Array.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp b/third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

index 0b360091cebf6e8ce9d9711601b8df1984dae18b..f27feffd999063ecc9db896326be7a496eed9293 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

+++ b/third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

@@ -13,8 +13,12 @@ ErrorSupport::ErrorSupport() : m_errorString(nullptr) { }

ErrorSupport::ErrorSupport(String16* errorString) : m_errorString(errorString) { }

ErrorSupport::~ErrorSupport()

{

- if (m_errorString && hasErrors())

- *m_errorString = "Internal error(s): " + errors();

+ if (m_errorString && hasErrors()) {

+ String16Builder builder;

+ builder.append("Internal error(s): ");

+ builder.append(errors());

+ *m_errorString = builder.toString();

+ }

}

void ErrorSupport::setName(const String16& name)