third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp - Issue 1779033003: DevTools: always use 16bit strings for inspector protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 1779033003: DevTools: always use 16bit strings for inspector protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

index d112a224486e198b6cdff00ebf58fe2f97eefe84..ee2adb60987536634dbc899626787f867d083555 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

@@ -113,10 +113,7 @@ static String16 calculateHash(const String16& str)

size_t current = 0;

const uint32_t* data = nullptr;

- if (str.is8Bit())

- data = reinterpret_cast<const uint32_t*>(str.characters8());

- else

- data = reinterpret_cast<const uint32_t*>(str.characters16());

+ data = reinterpret_cast<const uint32_t*>(str.characters16());

for (size_t i = 0; i < str.sizeInBytes() / 4; i += 4) {

uint32_t v = data[i];

uint64_t xi = v * randomOdd[current] & 0x7FFFFFFF;

@@ -1084,7 +1081,7 @@ void V8DebuggerAgentImpl::traceAsyncCallbackCompleted()

{

if (!m_nestedAsyncCallCount)

return;

- ASSERT(m_currentAsyncCallChain);

+// ASSERT(m_currentAsyncCallChain);

--m_nestedAsyncCallCount;

if (!m_nestedAsyncCallCount) {

clearCurrentAsyncOperation();