Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1771353009: Revert of Mojo C++ bindings: replace '::' with '.' in the interface name. (Closed)

Created:
4 years, 9 months ago by Dirk Pranke
Modified:
4 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo C++ bindings: replace '::' with '.' in the interface name. (patchset #3 id:40001 of https://codereview.chromium.org/1778793004/ ) Reason for revert: I think this broke the harness-tests/mojo-helpers.html layout test: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=harness-tests%2Fmojo-helpers.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/61800 Original issue's description: > Mojo C++ bindings: replace '::' with '.' in the interface name. > > Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it > becomes "foo.Bar". > > Using C++-style namespace in the name doesn't makes too much sense because the > name should remain the same across different languages. > > BUG=None > > Committed: https://crrev.com/026e10b3842af957773aee40dc3736eecb7faa0c > Cr-Commit-Position: refs/heads/master@{#380301} TBR=ben@chromium.org,yzshen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/9fcf4efe81ba396b4afe653c92424ce3fc55ee42 Cr-Commit-Position: refs/heads/master@{#380328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M content/browser/mojo/chrome_renderer_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/connect/connect_unittests_manifest.json View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/shell/tests/shell/target_manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
Created Revert of Mojo C++ bindings: replace '::' with '.' in the interface name.
4 years, 9 months ago (2016-03-10 03:59:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771353009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771353009/1
4 years, 9 months ago (2016-03-10 03:59:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 04:00:55 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 04:02:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fcf4efe81ba396b4afe653c92424ce3fc55ee42
Cr-Commit-Position: refs/heads/master@{#380328}

Powered by Google App Engine
This is Rietveld 408576698