Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1778763002: Prepare remoting/ for compilation with OS X 10.7 deployment target. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
Reviewers:
Sergey Ulanov, Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp89_107_base4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare remoting/ for compilation with OS X 10.7 deployment target. Now that base/ compiles as a 64-bit target, there is no reason for remoting/ to duplicate logic. The logic in base/ has been updated to not emit compile warning when compiling with a OS X 10.7 deployment target. BUG=592663 Committed: https://crrev.com/8aef985913eecbaec3866825f4d502d96a321c2e Cr-Commit-Position: refs/heads/master@{#380027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -138 lines) Patch
M remoting/host/installer/mac/uninstaller/remoting_uninstaller.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M remoting/host/mac/me2me_preference_pane.mm View 2 chunks +2 lines, -133 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
erikchen
sergeyu: Please review.
4 years, 9 months ago (2016-03-09 01:00:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778763002/1
4 years, 9 months ago (2016-03-09 01:01:54 UTC) #4
Lambros
lgtm nit: In CL description: "updating to not emit compiling warning when" 'updated' and ('compile' ...
4 years, 9 months ago (2016-03-09 01:15:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 01:40:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778763002/1
4 years, 9 months ago (2016-03-09 01:44:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 01:50:41 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 01:52:33 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8aef985913eecbaec3866825f4d502d96a321c2e
Cr-Commit-Position: refs/heads/master@{#380027}

Powered by Google App Engine
This is Rietveld 408576698