Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1776253002:
Remove references to CWNetwork. (Closed)
|
Created:
4 years, 9 months ago by erikchen Modified:
4 years, 9 months ago CC:
chromium-reviews, darin-cc_chromium.org, Michael van Ouwerkerk, jam, mlamouri+watch-geolocation_chromium.org, vmpstr+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@temp89_107_remoting Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove references to CWNetwork.
Chrome no longer supports OS X 10.6.
BUG=592663
Committed: https://crrev.com/7bea53f048244f5d6d117c5484733130d3248009
Cr-Commit-Position: refs/heads/master@{#380677}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add a missing include. #Patch Set 3 : Rebase. #Patch Set 4 : Fix compile error. #
Messages
Total messages: 36 (15 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776253002/1
erikchen@chromium.org changed reviewers: + mark@chromium.org, mef@chromium.org, mvanouwerkerk@chromium.org
mark: Please review base/ mef: Please review components/wifi/wifi_service_mac.mm mvanouwerkerk: Please review content/browser/geolocation/wifi_data_provider_corewlan_mac.mm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Trybot failures!
https://codereview.chromium.org/1776253002/diff/1/content/browser/geolocation... File content/browser/geolocation/wifi_data_provider_corewlan_mac.mm (right): https://codereview.chromium.org/1776253002/diff/1/content/browser/geolocation... content/browser/geolocation/wifi_data_provider_corewlan_mac.mm:161: access_point_data.radio_signal_strength = [network rssiValue]; According to the try bots this does not work: ../../content/browser/geolocation/wifi_data_provider_corewlan_mac.mm:161:58: error: instance method '-rssiValue' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access] access_point_data.radio_signal_strength = [network rssiValue];
On 2016/03/09 10:09:46, Michael van Ouwerkerk wrote: > https://codereview.chromium.org/1776253002/diff/1/content/browser/geolocation... > File content/browser/geolocation/wifi_data_provider_corewlan_mac.mm (right): > > https://codereview.chromium.org/1776253002/diff/1/content/browser/geolocation... > content/browser/geolocation/wifi_data_provider_corewlan_mac.mm:161: > access_point_data.radio_signal_strength = [network rssiValue]; > According to the try bots this does not work: > > ../../content/browser/geolocation/wifi_data_provider_corewlan_mac.mm:161:58: > error: instance method '-rssiValue' not found (return type defaults to 'id') > [-Werror,-Wobjc-method-access] > access_point_data.radio_signal_strength = [network rssiValue]; components/wifi/wifi_service_mac.mm lgtm
On 2016/03/09 10:09:46, Michael van Ouwerkerk wrote: > https://codereview.chromium.org/1776253002/diff/1/content/browser/geolocation... > File content/browser/geolocation/wifi_data_provider_corewlan_mac.mm (right): > > https://codereview.chromium.org/1776253002/diff/1/content/browser/geolocation... > content/browser/geolocation/wifi_data_provider_corewlan_mac.mm:161: > access_point_data.radio_signal_strength = [network rssiValue]; > According to the try bots this does not work: > > ../../content/browser/geolocation/wifi_data_provider_corewlan_mac.mm:161:58: > error: instance method '-rssiValue' not found (return type defaults to 'id') > [-Werror,-Wobjc-method-access] > access_point_data.radio_signal_strength = [network rssiValue]; yeah, I looked at this last night, but didn't have a machine to actually edit the patch. I'm just missing an include of sdk_forward_declarations. Once we actually bump the deployment target, we won't need that either.
LGTM with green bots (obviously)
geolocation lgtm Thanks!
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org, mef@chromium.org, mvanouwerkerk@chromium.org Link to the patchset: https://codereview.chromium.org/1776253002/#ps20001 (title: "Add a missing include.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776253002/20001
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org, mef@chromium.org, mvanouwerkerk@chromium.org Link to the patchset: https://codereview.chromium.org/1776253002/#ps60001 (title: "Fix compile error.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776253002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776253002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776253002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776253002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove references to CWNetwork. Chrome no longer supports OS X 10.6. BUG=592663 ========== to ========== Remove references to CWNetwork. Chrome no longer supports OS X 10.6. BUG=592663 Committed: https://crrev.com/7bea53f048244f5d6d117c5484733130d3248009 Cr-Commit-Position: refs/heads/master@{#380677} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/7bea53f048244f5d6d117c5484733130d3248009 Cr-Commit-Position: refs/heads/master@{#380677} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
