Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1773303002: Prepare base/ for compilation with OS X 10.7 deployment target. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare base/ for compilation with OS X 10.7 deployment target. Disable deprecation warnings for AuthorizationExecuteWithPrivileges, which has been deprecated since OS X 10.7. Update the forward declaration of -[NSEvent stage] to have the appropriate semantics. It was introduced in OS X 10.10.3. BUG=592663, 593133 Committed: https://crrev.com/bd736b069b320a18476b30aea47639fb25f50110 Cr-Commit-Position: refs/heads/master@{#379969}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M base/mac/authorization_util.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M base/mac/sdk_forward_declarations.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
erikchen
mark: Please review.
4 years, 9 months ago (2016-03-08 21:39:00 UTC) #2
Mark Mentovai
LGTM
4 years, 9 months ago (2016-03-08 21:50:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773303002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773303002/40001
4 years, 9 months ago (2016-03-08 22:12:16 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 23:47:51 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 23:49:23 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd736b069b320a18476b30aea47639fb25f50110
Cr-Commit-Position: refs/heads/master@{#379969}

Powered by Google App Engine
This is Rietveld 408576698