Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1778443002: Use instance name to uniquify renderers. (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), James Su, ben+mojo_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@40fix2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use instance name to uniquify renderers. We were uniquifying their URLs, but this breaks manifest loading. So use instance names instead. This will allow us to move the capability filter spec for the renderers into a manifest. BUG= Committed: https://crrev.com/52850ee33c3c2e813ff4f3c295f67ad7d9e7df65 Cr-Commit-Position: refs/heads/master@{#379850}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -42 lines) Patch
M content/browser/mojo/mojo_shell_client_host.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 3 chunks +25 lines, -35 lines 1 comment Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/connector.h View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-08 14:55:53 UTC) #3
sky
LGTM https://codereview.chromium.org/1778443002/diff/1/content/browser/mojo/mojo_shell_client_host.cc File content/browser/mojo/mojo_shell_client_host.cc (right): https://codereview.chromium.org/1778443002/diff/1/content/browser/mojo/mojo_shell_client_host.cc#newcode36 content/browser/mojo/mojo_shell_client_host.cc:36: mojo::Identity get() const { return identity_; } const ...
4 years, 9 months ago (2016-03-08 17:22:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778443002/1
4 years, 9 months ago (2016-03-08 17:23:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 17:35:14 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 17:39:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52850ee33c3c2e813ff4f3c295f67ad7d9e7df65
Cr-Commit-Position: refs/heads/master@{#379850}

Powered by Google App Engine
This is Rietveld 408576698