Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1775793002: Fix chrome --mash (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chrome --mash Reduce the number of cases in which the resolved_qualifier is used. It should only be used in lieu of the one provided via params when it differs from the default qualifier for the resolved name. TBR=sky@chromium.org BUG= Committed: https://crrev.com/8629ce72e06a8e4dae428f0fbc3ba83cc5555407 Cr-Commit-Position: refs/heads/master@{#379834}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -25 lines) Patch
M mojo/shell/shell.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/shell/tests/connect/connect_test.mojom View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_package.cc View 1 2 6 chunks +12 lines, -6 lines 0 comments Download
M mojo/shell/tests/connect/connect_unittest.cc View 1 2 3 chunks +36 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-08 05:12:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775793002/40001
4 years, 9 months ago (2016-03-08 15:13:33 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 15:18:29 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8629ce72e06a8e4dae428f0fbc3ba83cc5555407 Cr-Commit-Position: refs/heads/master@{#379834}
4 years, 9 months ago (2016-03-08 15:19:44 UTC) #9
sky
4 years, 9 months ago (2016-03-08 16:38:38 UTC) #10
Message was sent while issue was closed.
Thanks! LGTM

Powered by Google App Engine
This is Rietveld 408576698