Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775813002: Eliminate CapabilityFilter parameter from CreateInstance, instead reading it from the associated ma… (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@41qual
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate CapabilityFilter parameter from CreateInstance, instead reading it from the associated manifest. BUG= Committed: https://crrev.com/66696d139202c1e760c6e004c36c96394b0f00e2 Cr-Commit-Position: refs/heads/master@{#379853}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -80 lines) Patch
M content/browser/BUILD.gn View 3 chunks +8 lines, -0 lines 0 comments Download
D content/browser/mojo/OWNERS View 1 1 chunk +0 lines, -13 lines 1 comment Download
A content/browser/mojo/chrome_renderer_manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/mojo/renderer_capability_filter.cc View 1 1 chunk +0 lines, -29 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/shell.cc View 3 chunks +24 lines, -7 lines 0 comments Download
M mojo/shell/tests/lifecycle/exe_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/lifecycle/lifecycle_unittest.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M mojo/shell/tests/shell/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/shell/tests/shell/driver.cc View 2 chunks +1 line, -8 lines 0 comments Download
A mojo/shell/tests/shell/target_manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1778443002 Patch 1

Messages

Total messages: 10 (3 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-08 06:46:43 UTC) #2
sky
https://codereview.chromium.org/1775813002/diff/20001/content/browser/mojo/OWNERS File content/browser/mojo/OWNERS (left): https://codereview.chromium.org/1775813002/diff/20001/content/browser/mojo/OWNERS#oldcode3 content/browser/mojo/OWNERS:3: per-file renderer_capability_filter.cc=set noparent As the capabilities are now expressed ...
4 years, 9 months ago (2016-03-08 16:52:37 UTC) #3
sky
LGTM
4 years, 9 months ago (2016-03-08 17:22:30 UTC) #4
Ben Goodger (Google)
On 2016/03/08 16:52:37, sky wrote: > https://codereview.chromium.org/1775813002/diff/20001/content/browser/mojo/OWNERS > File content/browser/mojo/OWNERS (left): > > https://codereview.chromium.org/1775813002/diff/20001/content/browser/mojo/OWNERS#oldcode3 > ...
4 years, 9 months ago (2016-03-08 17:22:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775813002/20001
4 years, 9 months ago (2016-03-08 17:43:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 17:48:12 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 17:50:10 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/66696d139202c1e760c6e004c36c96394b0f00e2
Cr-Commit-Position: refs/heads/master@{#379853}

Powered by Google App Engine
This is Rietveld 408576698