Issue 1778363003: Improve search for constructors and import elements.

Issue 1778363003: Improve search for constructors and import elements. (Closed)

Created:
4 years, 9 months ago by scheglov

Modified:
4 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Improve search for constructors and import elements. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4e8e1e2e04142b682fd57bbcd39aa944f0b927da

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -26 lines)			Patch
M	pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart	View	2 chunks	+7 lines, -2 lines	1 comment	Download
M	pkg/analysis_server/test/services/search/search_engine2_test.dart	View	5 chunks	+33 lines, -7 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/index_unit.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/src/summary/index_unit_test.dart	View	6 chunks	+70 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1778363003/diff/1/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart File pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart (right): https://codereview.chromium.org/1778363003/diff/1/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart#newcode293 pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart:293: visitImportDirective(ImportDirective node) {} Do we need to do ...

4 years, 9 months ago (2016-03-10 21:08:15 UTC) #2

scheglov

4 years, 9 months ago (2016-03-10 22:57:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e8e1e2e04142b682fd57bbcd39aa944f0b927da (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages