Improve search for constructors and import elements.

pkg/analysis_server/test/services/search/search_engine2_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.src.search.search_engine2;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/services/index2/index2.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
@@ skipping 239 matching lines @@
       _expectId(main, MatchKind.READ, 'field); // ref-nq'),
       _expectIdQ(main, MatchKind.READ, 'field); // ref-q'),
       _expectId(main, MatchKind.INVOCATION, 'field(); // inv-nq'),
       _expectIdQ(main, MatchKind.INVOCATION, 'field(); // inv-q'),
       _expectId(main, MatchKind.WRITE, 'field = 2; // ref-nq'),
       _expectIdQ(main, MatchKind.WRITE, 'field = 3; // ref-q'),
     ];
     await _verifyReferences(element, expected);
   }
 
+  test_searchReferences_FieldElement_synthetic() async {
+    _indexTestUnit('''
+class A {
+  get field => null;
+  set field(x) {}
+  main() {
+    // getter
+    print(field); // ref-nq
+    print(this.field); // ref-q
+    field(); // inv-nq
+    this.field(); // inv-q
+    // setter
+    field = 2; // ref-nq;
+    this.field = 3; // ref-q;
+  }
+}
+''');
+    FieldElement element = findElement('field', ElementKind.FIELD);
+    Element main = findElement('main');
+    var expected = [
+      _expectId(main, MatchKind.READ, 'field); // ref-nq'),
+      _expectIdQ(main, MatchKind.READ, 'field); // ref-q'),
+      _expectId(main, MatchKind.INVOCATION, 'field(); // inv-nq'),
+      _expectIdQ(main, MatchKind.INVOCATION, 'field(); // inv-q'),
+      _expectId(main, MatchKind.WRITE, 'field = 2; // ref-nq'),
+      _expectIdQ(main, MatchKind.WRITE, 'field = 3; // ref-q'),
+    ];
+    await _verifyReferences(element, expected);
+  }
+
   test_searchReferences_FunctionElement() async {
     _indexTestUnit('''
 test() {}
 main() {
   test();
   print(test);
 }
 ''');
     FunctionElement element = findElement('test');
     Element mainElement = findElement('main');
@@ skipping 34 matching lines @@
     Element bElement = findElement('b');
     var expected = [
       _expectId(aElement, MatchKind.REFERENCE, 'Test a;'),
       _expectId(bElement, MatchKind.REFERENCE, 'Test b;')
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_ImportElement_noPrefix() async {
     _indexTestUnit('''
-import 'dart:math';
+import 'dart:math' show max, PI, Random;
 main() {
   print(PI);
   print(new Random());
   print(max(1, 2));
 }
 Random bar() => null;
 ''');
     ImportElement element = testLibraryElement.imports[0];
     Element mainElement = findElement('main');
     Element barElement = findElement('bar');
     var kind = MatchKind.REFERENCE;
     var expected = [
       _expectId(mainElement, kind, 'PI);', length: 0),
       _expectId(mainElement, kind, 'Random()', length: 0),
       _expectId(mainElement, kind, 'max(', length: 0),
       _expectId(barElement, kind, 'Random bar()', length: 0),
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_ImportElement_withPrefix() async {
     _indexTestUnit('''
-import 'dart:math' as math;
+import 'dart:math' as math show max, PI, Random;
 main() {
   print(math.PI);
   print(new math.Random());
   print(math.max(1, 2));
 }
 math.Random bar() => null;
 ''');
     ImportElement element = testLibraryElement.imports[0];
     Element mainElement = findElement('main');
     Element barElement = findElement('bar');
@@ skipping 357 matching lines @@
     }
     return new ExpectedMatch(element, kind, offset, length,
         isResolved: isResolved, isQualified: isQualified);
   }
 
   ExpectedMatch _expectIdQ(Element element, MatchKind kind, String search,
       {int length}) {
     return _expectId(element, kind, search, isQualified: true, length: length);
   }
 
-//  ExpectedMatch _expectIdU(Element element, MatchKind kind, String search) {
-//    return _expectId(element, kind, search,
-//        isQualified: true, isResolved: false);
-//  }
-
   void _indexTestUnit(String code) {
     resolveTestUnit(code);
     index.indexUnit(testUnit);
   }
 
   Future _verifyReferences(
       Element element, List<ExpectedMatch> expectedMatches) async {
     List<SearchMatch> matches = await searchEngine.searchReferences(element);
     _assertMatches(matches, expectedMatches);
+    expect(matches, hasLength(expectedMatches.length));
   }
 
   static void _assertMatches(
       List<SearchMatch> matches, List<ExpectedMatch> expectedMatches) {
     expect(matches, unorderedEquals(expectedMatches));
   }
 }