Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart

Issue 1778363003: Improve search for constructors and import elements. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/search/search_engine2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
diff --git a/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart b/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
index 953f6c34f229f0bfe51cd4ba26b3a3af7745478b..4ad5898386c454d94e5e609ac90a733c307976fb 100644
--- a/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
+++ b/pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart
@@ -141,8 +141,10 @@ class SearchEngineImpl2 implements SearchEngine {
PropertyAccessorElement getter = field.getter;
PropertyAccessorElement setter = field.setter;
// field itself
- await _addMatches(matches, field, IndexRelationKind.IS_REFERENCED_BY,
- MatchKind.REFERENCE);
+ if (!field.isSynthetic) {
+ await _addMatches(matches, field, IndexRelationKind.IS_REFERENCED_BY,
+ MatchKind.REFERENCE);
+ }
// getter
if (getter != null) {
await _addMatches(
@@ -288,6 +290,9 @@ class _ImportElementReferencesVisitor extends RecursiveAstVisitor {
}
@override
+ visitImportDirective(ImportDirective node) {}
Brian Wilkerson 2016/03/10 21:08:14 Do we need to do the equivalent for export directi
+
+ @override
visitSimpleIdentifier(SimpleIdentifier node) {
if (node.inDeclarationContext()) {
return;
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/search/search_engine2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698