Recipe changes to move webview perf bots to the android/perf recipe

Recipe changes to move android webiew perf bot to the android/perf recipe.
This change is motivated by us getting 2 new WebView perf bots and I would
like to use the sharding logic in the android/perf recipe for the new
bots.

BUG=590800
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299994

[mikecase (-- gone --), 2016-03-10 02:22:38]

mikecase@chromium.org changed reviewers:
+ sullivan@chromium.org, yolandyan@chromium.org

[mikecase (-- gone --), 2016-03-10 02:23:11]

On 2016/03/10 at 02:22:38, mikecase wrote:
> 

This would have to be committed after https://codereview.chromium.org/1748003002

[mikecase (-- gone --), 2016-04-13 21:51:09]

Description was changed from

==========
Recipe changes to move android webiew perf bot to main waterfall.

BUG=590800
==========

to

==========
Recipe changes to move android webiew perf bot to the android/perf recipe.
This change is motivated by us getting 2 new WebView perf bots and I would
like to use the sharding logic in the android/perf recipe for the new
bots.

BUG=590800
==========

[mikecase (-- gone --), 2016-04-13 22:01:12]

mikecase@chromium.org changed reviewers:
+ bpastene@chromium.org

[mikecase (-- gone --), 2016-04-13 22:01:13]

PTAL

I changed this CL around a bit. This CL now doesn't move the WebView bots to the
main waterfall
but does move the WebView perf bots onto the android/perf.py recipe.

This is mainly to consolidate the perf recipes and use the sharding logic in
android perf
for 2 new Nexus 5X bots we got for WebView.

+bpastene
There is no builder on the chromium.perf.fyi waterfall so I tried to set the
WebView fyi perf bots to get triggered by the builder on chromium.perf. Please
take a look to see if I did should work.

[sullivan, 2016-04-14 13:46:42]

sullivan@chromium.org changed reviewers:
+ dtu@chromium.org

[sullivan, 2016-04-14 13:46:42]

I'm okay with the high-level changes here (and future high-level changes to move
this onto the chromium.perf waterfall), but full code review should be done by
dtu.

[bpastene, 2016-04-14 18:55:29]

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
File scripts/slave/recipes/android/builder.py (right):

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
scripts/slave/recipes/android/builder.py:219: api.trigger(*[{'mastername':
b['mastername'],
I believe you'll want to add the tag {'bucket': b['mastername']} to this list.
This is how it knows to trigger on another master, otherwise it defaults to the
current master. Also, the value has to be prefixed with 'master.'

[dtu, 2016-04-14 19:24:25]

lgtm

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
File scripts/slave/recipes/android/perf.py (right):

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.py:29: def create_shard_test_spec(name,
perf_id, required_apks, num_device_shards,
_CreateShardTestSpec (Chromium style)

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.py:88: def _ChromiumFYIPerfTesters():
_ChromiumPerfFYITesters

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.py:90: _CreateTestSpec('Android Nexus5
WebView Perf', 'android-webivew',
webview misspelled. below as well

[mikecase (-- gone --), 2016-04-15 21:23:17]

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
File scripts/slave/recipes/android/builder.py (right):

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
scripts/slave/recipes/android/builder.py:219: api.trigger(*[{'mastername':
b['mastername'],
On 2016/04/14 at 18:55:29, bpastene wrote:
> I believe you'll want to add the tag {'bucket': b['mastername']} to this list.
This is how it knows to trigger on another master, otherwise it defaults to the
current master. Also, the value has to be prefixed with 'master.'

Done. Added 

'bucket': b['mastername'], 

to the list.

It seems like "master." is automagically prepended. When I add "master." I got
something like..
+          "bucket": "master.master.chromium.perf.fyi",
in my expectation files.

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
File scripts/slave/recipes/android/perf.py (right):

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.py:29: def create_shard_test_spec(name,
perf_id, required_apks, num_device_shards,
On 2016/04/14 at 19:24:24, dtu wrote:
> _CreateShardTestSpec (Chromium style)

Done

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.py:88: def _ChromiumFYIPerfTesters():
On 2016/04/14 at 19:24:24, dtu wrote:
> _ChromiumPerfFYITesters

Done

https://codereview.chromium.org/1777863005/diff/40001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.py:90: _CreateTestSpec('Android Nexus5
WebView Perf', 'android-webivew',
On 2016/04/14 at 19:24:24, dtu wrote:
> webview misspelled. below as well

nice catch, ty

[mikecase (-- gone --), 2016-04-18 16:26:14]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-04-18 16:26:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org
Link to the patchset: https://codereview.chromium.org/1777863005/#ps60001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-04-18 16:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777863005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777863005/60001

[commit-bot: I haz the power, 2016-04-18 16:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 16:28:54]

Try jobs failed on following builders:
  Build Try Recipe Test Trusty64 on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Try%20Recipe%20...)

[mikecase (-- gone --), 2016-04-18 18:37:14]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2016-04-18 18:37:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org
Link to the patchset: https://codereview.chromium.org/1777863005/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-04-18 18:37:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777863005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777863005/80001

[commit-bot: I haz the power, 2016-04-18 18:41:42]

Description was changed from

==========
Recipe changes to move android webiew perf bot to the android/perf recipe.
This change is motivated by us getting 2 new WebView perf bots and I would
like to use the sharding logic in the android/perf recipe for the new
bots.

BUG=590800
==========

to

==========
Recipe changes to move android webiew perf bot to the android/perf recipe.
This change is motivated by us getting 2 new WebView perf bots and I would
like to use the sharding logic in the android/perf recipe for the new
bots.

BUG=590800

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299994
==========

[commit-bot: I haz the power, 2016-04-18 18:41:43]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299994

[nodir, 2016-04-20 18:03:39]

nodir@chromium.org changed reviewers:
+ nodir@chromium.org

[nodir, 2016-04-20 18:03:40]

https://codereview.chromium.org/1777863005/diff/80001/scripts/slave/recipes/a...
File scripts/slave/recipes/android/builder.py (right):

https://codereview.chromium.org/1777863005/diff/80001/scripts/slave/recipes/a...
scripts/slave/recipes/android/builder.py:222: 'revision':
api.properties['revision']}
The structure of this dict should be something like

{
  'bucket': ...
  'builder_name': ... # note the underscore
  'properties': {'revision': ...},
}

buildername and mastername properties are buildbot-builtin and set by master.

docs:
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...

I recommend to test this with a local buildbot master