Recipe changes to move webview perf bots to the android/perf recipe

scripts/slave/recipes/android/builder.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from contextlib import contextmanager
 from recipe_engine import recipe_api
 from recipe_engine.types import freeze
 
 DEPS = [
   'chromium',
   'chromium_android',
   'depot_tools/bot_update',
   'depot_tools/gclient',
   'recipe_engine/path',
   'recipe_engine/properties',
   'recipe_engine/step',
   'depot_tools/tryserver',
+  'trigger',
 ]
 
 @contextmanager
 def FYIStep():
   try:
     yield
   except recipe_api.StepFailure:
     pass
 
 BUILDERS = freeze({
@@ skipping 29 matching lines @@
       'run_mb': True,
       'targets': [
         'android_tools',
         'cc_perftests',
         'chrome_public_apk',
         'gpu_perftests',
         'push_apps_to_background_apk',
         'system_webview_apk',
         'system_webview_shell_apk',
       ],
+      'triggers': [
+        {
+          'buildername': 'WebView Nexus5 Perf (1)',
+          'mastername': 'chromium.perf.fyi',
+        },
+        {
+          'buildername': 'WebView Nexus5X Perf (1)',
+          'mastername': 'chromium.perf.fyi',
+        },
+        {
+          'buildername': 'WebView Nexus5X Perf (2)',
+          'mastername': 'chromium.perf.fyi',
+        }
+      ]
     },
     'Android arm64 Builder': {
       'recipe_config': 'arm64_builder_rel_mb',
       'gclient_apply_config': ['android', 'perf'],
       'kwargs': {
         'BUILD_CONFIG': 'Release',
       },
       'upload': {
         'bucket': 'chrome-perf',
         'path': lambda api: (
@@ skipping 115 matching lines @@
 
   upload_config = bot_config.get('upload')
   if upload_config:
     droid.upload_build(upload_config['bucket'],
                        upload_config['path'](api))
 
   upload_config = bot_config.get('zip_and_upload')
   if upload_config:
     droid.zip_and_upload_build(upload_config['bucket'])
 
+  # TODO(mikecase): Remove this logic once WebView bots are on chromium.perf
+  if bot_config.get('triggers'):
+    api.trigger(*[{'mastername': b['mastername'],

[bpastene, 2016/04/14 18:55:29]

I believe you'll want to add the tag {'bucket': b['mastername']} to this list.
This is how it knows to trigger on another master, otherwise it defaults to the
current master. Also, the value has to be prefixed with 'master.'

[mikecase (-- gone --), 2016/04/15 21:23:17]

Done. Added 

'bucket': b['mastername'], 

to the list.

It seems like "master." is automagically prepended. When I add "master." I got
something like..
+          "bucket": "master.master.chromium.perf.fyi",
in my expectation files.

+                   'buildername': b['buildername'],
+                   'revision': api.properties['revision']}
+                  for b in bot_config['triggers']])
 
 def RunSteps(api, mastername, buildername, revision):
   with api.tryserver.set_failure_hash():
     return _RunStepsInternal(api, mastername, buildername, revision)
 
 
 def _sanitize_nonalpha(text):
   return ''.join(c if c.isalnum() else '_' for c in text)
 
 
@@ skipping 22 matching lines @@
         '_'.join(_sanitize_nonalpha(step) for step in steps))) +
       props(mastername=mastername, buildername=buildername) +
       reduce(lambda a, b: a + b,
              (api.step_data(step, retcode=1) for step in steps))
     )
 
   yield step_failure(mastername='chromium.android',
                      buildername='Android x64 Builder (dbg)',
                      steps=['check licenses'])