Move android webview perf bot from fyi to main perf waterfall

Move android webview perf bot from fyi to main perf waterfall

Please check bug for more detail

BUG=590800

[Yoland Yan(Google), 2016-02-29 18:44:24]

yolandyan@google.com changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org, rnephew@google.com

[Yoland Yan(Google), 2016-02-29 18:44:52]

Description was changed from

==========
Move android webview perf bot from fyi to main perf waterfall

BUG=590800
==========

to

==========
Move android webview perf bot from fyi to main perf waterfall

Please check bug for more detail

BUG=590800
==========

[rnephew (Wrong account), 2016-02-29 18:46:09]

rnephew@google.com changed reviewers:
+ dtu@chromium.org, sullivan@chromium.org

[rnephew (Wrong account), 2016-02-29 18:46:09]

adding dtu@ and sullivan@

[sullivan, 2016-02-29 18:56:11]

sullivan@chromium.org changed reviewers:
+ kerz@chromium.org

[sullivan, 2016-02-29 18:56:11]

+kerz

I LOVE the idea of getting the WebView perf bots on the main waterfall where
they can be properly maintained by the sheriffs, and I agree they do look stable
enough for this.

But three issues, two major, one minor:

1. The first major issue is that I'd really like to see a clear plan for which
devices we plan do do WebView testing on and why. Are we only going to use Nexus
5? Are we going to extend to the entire scope of the perf waterfall (n5, n5x,
n6, n7v2, n9, a1, s5)? Do we need to do any internal waterfall testing?

2. The second major issue is where are the bisect bots?

3. The minor issue is that it looks like the builder currently only has 6
devices attached instead of our standard 7. Why is this?
https://build.chromium.org/p/chromium.perf.fyi/builders/android_webview_aosp_...

[rnephew (Wrong account), 2016-02-29 19:00:41]

> 2. The second major issue is where are the bisect bots? 
Case did set up a single bisect bot. He can give more information on this, but
it does exist.

> 3. The minor issue is that it looks like the builder currently only has 6
> devices attached instead of our standard 7. Why is this?
>
https://build.chromium.org/p/chromium.perf.fyi/builders/android_webview_aosp_...
There was a problem that is now fixed where devices can disappear if adb and
lsusb cannot find them. This could be what is going on here. We should have
someone go into the lab and look to make sure there aren't actually 7 hooked up
with one dead.

[Yoland Yan(Google), 2016-02-29 19:51:40]

yolandyan@google.com changed reviewers:
+ qyearsley@chromium.org, sgurun@chromium.org

[Yoland Yan(Google), 2016-02-29 19:51:41]

+selim, +qyearsley

For 1,
We don't have a specific plan for increasing the scope/number of devices. But I
really hope we get more to speed up the runs. Also for N features, we also need
n5x devices (from Peruz crbug/585761)
I can look into getting more devices (crbug/ to keep track of the progress)

For 2,
The master and builder name will change for the perf bot. So hopefully changing
the configs for the current bisect bot shouldn't result in any problem
(+qyearsley)

[Yoland Yan(Google), 2016-02-29 19:58:07]

On 2016/02/29 19:51:41, yolandyan wrote:
> +selim, +qyearsley
> 
> For 1,
> We don't have a specific plan for increasing the scope/number of devices. But
I
> really hope we get more to speed up the runs. Also for N features, we also
need
> n5x devices (from Peruz crbug/585761)
> I can look into getting more devices (crbug/ to keep track of the progress)
> 
> For 2,
> The master and builder name will change for the perf bot. So hopefully
changing
> the configs for the current bisect bot shouldn't result in any problem
> (+qyearsley)

Sorry the crbug to keep track of the progress is crbug.com/590844

[mikecase (-- gone --), 2016-03-10 02:22:01]

Few comments...

1. No changes are needed to the bisect bots in recipes for this CL. We will just
need qyearsley@'s help getting this new main waterfall WebView perf bot to be
able to 
trigger the bisects from the dashboard.

2. No idea about the number of devices. In the recipe, it looks like the tests
are
explicitly sharded across 5 devices. idk why

3. And about recipes. Will need to at minimum update the builder/master name in
the 
android_webview_aosp_perf.py recipe. In a local branch, I had the change to move
the WebView
bot to the same recipe as the other perf bots if it ever got moved to the main
waterfall.
I could just commit that before this is committed.
Uploaded it here: https://codereview.chromium.org/1777863005

https://codereview.chromium.org/1748003002/diff/1/masters/master.chromium.per...
File masters/master.chromium.perf/slaves.cfg (right):

https://codereview.chromium.org/1748003002/diff/1/masters/master.chromium.per...
masters/master.chromium.perf/slaves.cfg:61: 'Android Nexus5 Perf', 'linux',
'trusty',
Need to be 'Android Nexus5 WebView Perf' I think.