gin/run_microtasks_observer.h - Issue 1777183002: Revert of Use v8::MicrotasksScope internally in V8RecursionScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/run_microtasks_observer.h

Issue 1777183002: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope

Patch Set: Resolve patch conflict Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/run_microtasks_observer.h

diff --git a/gin/run_microtasks_observer.h b/gin/run_microtasks_observer.h

index ca160bed6090800010ac650102aa963a6b9fbc70..7f1431fb2ec253f579e1f487aa9ffc2759d9c6d6 100644

--- a/gin/run_microtasks_observer.h

+++ b/gin/run_microtasks_observer.h

@@ -12,7 +12,7 @@ namespace gin {

// Runs any pending v8 Microtasks each time a task is completed.

// TODO(hansmuller); At some point perhaps this can be replaced with

-// the (currently experimental) v8::MicrotasksPolicy::kAuto method.

+// the (currently experimental) Isolate::SetAutorunMicrotasks() method.

class RunMicrotasksObserver : public base::MessageLoop::TaskObserver {

public:

« no previous file with comments | « extensions/renderer/safe_builtins.cc ('k') | gin/run_microtasks_observer.cc » ('j') | no next file with comments »