Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1777163003: OnStreamEnd is now called instead of the sentinel call of OnStreamFrameData(stream_id, nullptr, 0, … (Closed)

Created:
4 years, 9 months ago by rjshade
Modified:
4 years, 9 months ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dahollings_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@116266391
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OnStreamEnd is now called instead of the sentinel call of OnStreamFrameData(stream_id, nullptr, 0, true). Protected by the flag FLAGS_spdy_on_stream_end. Merge internal change: 116272960 BUG=

Patch Set 1 #

Patch Set 2 : Merge spdy_framer_test.cc #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -57 lines) Patch
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +2 lines, -1 line 1 comment Download
M net/quic/quic_headers_stream_test.cc View 18 chunks +46 lines, -32 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 4 chunks +14 lines, -4 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 21 chunks +321 lines, -20 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (2 generated)
rjshade
4 years, 9 months ago (2016-03-10 23:16:26 UTC) #3
Ryan Hamilton
4 years, 9 months ago (2016-03-10 23:21:14 UTC) #4
https://codereview.chromium.org/1777163003/diff/20001/net/quic/quic_headers_s...
File net/quic/quic_headers_stream.cc (right):

https://codereview.chromium.org/1777163003/diff/20001/net/quic/quic_headers_s...
net/quic/quic_headers_stream.cc:70: // or SYN_REPLY frame that had the fin bit
set.
Hm. I think we actually need to do something here. If you look at
QuicHeadersStream::OnControlFrameHeaderData, it looks to me like that code
expects len == 0. Do the tests pass with this CL (and flag = true)?

Powered by Google App Engine
This is Rietveld 408576698