net/quic/quic_headers_stream.cc - Issue 1777163003: OnStreamEnd is now called instead of the sentinel call of OnStreamFrameData(stream_id, nullptr, 0, …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_headers_stream.cc

Issue 1777163003: OnStreamEnd is now called instead of the sentinel call of OnStreamFrameData(stream_id, nullptr, 0, … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116266391

Patch Set: Merge spdy_framer_test.cc Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_headers_stream.cc

diff --git a/net/quic/quic_headers_stream.cc b/net/quic/quic_headers_stream.cc

index b62717c2178057883e7bfe317cc671a7a2fc61cc..88a6186cf3495549149331978d46f07d3c5ed1e4 100644

--- a/net/quic/quic_headers_stream.cc

+++ b/net/quic/quic_headers_stream.cc

@@ -66,7 +66,8 @@ class QuicHeadersStream::SpdyFramerVisitor

}

void OnStreamEnd(SpdyStreamId stream_id) override {

- LOG(DFATAL) << "Unimplemented.";

+ // The framer invokes OnStreamEnd after processing a SYN_STREAM

+ // or SYN_REPLY frame that had the fin bit set.

Ryan Hamilton 2016/03/10 23:21:14 Hm. I think we actually need to do something here.

}

void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {

« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_headers_stream_test.cc » ('j') | no next file with comments »