Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: net/quic/quic_headers_stream.cc

Issue 1777163003: OnStreamEnd is now called instead of the sentinel call of OnStreamFrameData(stream_id, nullptr, 0, … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116266391
Patch Set: Merge spdy_framer_test.cc Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_headers_stream_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_headers_stream.h" 5 #include "net/quic/quic_headers_stream.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "net/quic/quic_bug_tracker.h" 10 #include "net/quic/quic_bug_tracker.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 if (fin && len == 0) { 59 if (fin && len == 0) {
60 // The framer invokes OnStreamFrameData with zero-length data and 60 // The framer invokes OnStreamFrameData with zero-length data and
61 // fin = true after processing a SYN_STREAM or SYN_REPLY frame 61 // fin = true after processing a SYN_STREAM or SYN_REPLY frame
62 // that had the fin bit set. 62 // that had the fin bit set.
63 return; 63 return;
64 } 64 }
65 CloseConnection("SPDY DATA frame received."); 65 CloseConnection("SPDY DATA frame received.");
66 } 66 }
67 67
68 void OnStreamEnd(SpdyStreamId stream_id) override { 68 void OnStreamEnd(SpdyStreamId stream_id) override {
69 LOG(DFATAL) << "Unimplemented."; 69 // The framer invokes OnStreamEnd after processing a SYN_STREAM
70 // or SYN_REPLY frame that had the fin bit set.
Ryan Hamilton 2016/03/10 23:21:14 Hm. I think we actually need to do something here.
70 } 71 }
71 72
72 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override { 73 void OnStreamPadding(SpdyStreamId stream_id, size_t len) override {
73 CloseConnection("SPDY frame padding received."); 74 CloseConnection("SPDY frame padding received.");
74 } 75 }
75 76
76 SpdyHeadersHandlerInterface* OnHeaderFrameStart( 77 SpdyHeadersHandlerInterface* OnHeaderFrameStart(
77 SpdyStreamId stream_id) override { 78 SpdyStreamId stream_id) override {
78 LOG(FATAL); 79 LOG(FATAL);
79 return nullptr; 80 return nullptr;
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 360
360 void QuicHeadersStream::OnCompressedFrameSize(size_t frame_len) { 361 void QuicHeadersStream::OnCompressedFrameSize(size_t frame_len) {
361 frame_len_ += frame_len; 362 frame_len_ += frame_len;
362 } 363 }
363 364
364 bool QuicHeadersStream::IsConnected() { 365 bool QuicHeadersStream::IsConnected() {
365 return session()->connection()->connected(); 366 return session()->connection()->connected();
366 } 367 }
367 368
368 } // namespace net 369 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/quic/quic_headers_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698